Chromium Code Reviews Chromium Code Reviews
Issue
12220101:
Minimal Chrome Frame with Aura. (Closed)
DescriptionMinimal Chrome Frame with Aura.
It builds and runs, but not a whole lot else. This change includes:
* ChromeFrameAutomationProvider is now OS_WIN only. In practice, this
has been the case for some time. Now it's formalized by giving the
implementation files the _win suffix.
* Automation messages and datatypes used exclusively by Chrome Frame now
use HWND directly rather than a toolkit-specific gfx typedef of one
since the requirement is that an actual HWND be sent over the
channel. A change in toolkit (e.g., switching to Aura) must not change
this. As a consequence of this change, some automation types and
messages are now only defined for OS_WIN builds.
* ExternalTabContainerWin is no longer derived from a NativeWidget type
(this was previously the case so that the ETCW could be notified of NW
lifecycle events). Now, in contrast, ETCW registers itself as an
observer of its Widget. Two additional lifecycle methods have been
added to WidgetObserver: OnWidgetCreated and OnWidgetDestroyed.
* ExternalTabContianerWin initializes its Widget with an instance of
DesktopNativeWidgetAura when use_aura.
* A special note about HWND IPC marshaling: this change adds a type
mapping from HWND to a generic HANDLE in ipc_message_utils.h, which
allows for the removal of a hack in content_message_generator.h to
marshal HWNDs.
This change reverts all of:
* r178752 -- Remove CF from all.gyp targets if use_aura is defined.
* r164590 -- Remove setup -> Chrome Frame dependency. Make it possible
to build an installer for Aura.
and portions of:
* r99993 -- Get chrome to link with USE_AURA
* r99787 -- Preliminary work to allow Chrome to build with USE_AURA.
BUG=171018
TEST=chrome_frame_tests provides good coverage in non-Aura builds.
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=185328
Patch Set 1 : comments #Patch Set 2 : #Patch Set 3 : sync to r184453 #
Total comments: 10
Patch Set 4 : addressed comments #Patch Set 5 : sync to r184970 #Patch Set 6 : removed inclusion of web_contents_view.h from automation_provider_win.h. see patch set 5 for trybot… #
Total comments: 14
Patch Set 7 : thanks robert #Patch Set 8 : revert install_worker.cc to un-break win64 build #Messages
Total messages: 19 (0 generated)
|
