Issue 12220082: IDL: Autogenerate thunk .cc file for PPB_View

Issue 12220082: IDL: Autogenerate thunk .cc file for PPB_View (Closed)

Created:
7 years, 10 months ago by teravest

Modified:
7 years, 10 months ago

Reviewers:
brettw

CC:
chromium-reviews

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

IDL: Autogenerate thunk .cc file for PPB_View BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182253

Patch Set 3 : #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+140 lines, -60 lines)			Patch
M	ppapi/api/dev/ppb_view_dev.idl	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	ppapi/api/ppb_view.idl	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	ppapi/generators/idl_thunk.py	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	ppapi/ppapi_shared.gypi	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	ppapi/shared_impl/ppb_view_shared.h	View	1	1 chunk	+8 lines, -0 lines	0 comments	Download
M	ppapi/shared_impl/ppb_view_shared.cc	View	1 2	2 chunks	+42 lines, -0 lines	0 comments	Download
M	ppapi/thunk/ppb_view_api.h	View	1	1 chunk	+9 lines, -5 lines	0 comments	Download
A	ppapi/thunk/ppb_view_dev_thunk.cc	View		1 chunk	+47 lines, -0 lines	0 comments	Download
M	ppapi/thunk/ppb_view_thunk.cc	View		2 chunks	+27 lines, -55 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

brettw

lgtm https://codereview.chromium.org/12220082/diff/3001/ppapi/shared_impl/ppb_view_shared.cc File ppapi/shared_impl/ppb_view_shared.cc (right): https://codereview.chromium.org/12220082/diff/3001/ppapi/shared_impl/ppb_view_shared.cc#newcode8 ppapi/shared_impl/ppb_view_shared.cc:8: bool IsRectVisible(const PP_Rect& rect) { Maybe IsRectNonempty would ...

7 years, 10 months ago (2013-02-12 18:48:02 UTC) #2

teravest

https://codereview.chromium.org/12220082/diff/3001/ppapi/shared_impl/ppb_view_shared.cc File ppapi/shared_impl/ppb_view_shared.cc (right): https://codereview.chromium.org/12220082/diff/3001/ppapi/shared_impl/ppb_view_shared.cc#newcode8 ppapi/shared_impl/ppb_view_shared.cc:8: bool IsRectVisible(const PP_Rect& rect) { On 2013/02/12 18:48:02, brettw ...

7 years, 10 months ago (2013-02-12 19:01:41 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/teravest@chromium.org/12220082/2014

7 years, 10 months ago (2013-02-12 21:13:23 UTC) #4

commit-bot: I haz the power

Retried try job too often on win_rel for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=110943

7 years, 10 months ago (2013-02-12 23:52:01 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/teravest@chromium.org/12220082/2014

7 years, 10 months ago (2013-02-13 15:29:47 UTC) #6

Message was sent while issue was closed.

Change committed as 182253

Expand Messages | Collapse Messages