Issue 12220070: Use static strings in autofill labeling.

Issue 12220070: Use static strings in autofill labeling. (Closed)

Created:
7 years, 10 months ago by Albert Bodenhamer

Modified:
7 years, 10 months ago

Reviewers:
Raman Kakilate, Ilya Sherman

CC:
chromium-reviews, Raman Kakilate, benquan, dhollowa+watch_chromium.org, ahutter, dbeam+watch-autofill_chromium.org, darin-cc_chromium.org, Dane Wallinga, dyu1, Albert Bodenhamer, estade+watch_chromium.org, Ilya Sherman

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Use static strings in autofill labeling. Local profiling shows a significant chunk of time goes into creating strings. Using static strings appears to resolve the performance issues seen in 173243 when tested locally. BUG=173243 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181751

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : Fix nit #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -23 lines)			Patch
	M	chrome/renderer/autofill/form_autofill_util.cc	View	1 2	17 chunks	+49 lines, -23 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Ilya Sherman

LGTM https://codereview.chromium.org/12220070/diff/2001/chrome/renderer/autofill/form_autofill_util.cc File chrome/renderer/autofill/form_autofill_util.cc (right): https://codereview.chromium.org/12220070/diff/2001/chrome/renderer/autofill/form_autofill_util.cc#newcode195 chrome/renderer/autofill/form_autofill_util.cc:195: CR_DEFINE_STATIC_LOCAL(WebString, kLabel, ("label")); nit: Please define these closer ...

7 years, 10 months ago (2013-02-11 05:50:30 UTC) #3

Albert Bodenhamer

https://codereview.chromium.org/12220070/diff/2001/chrome/renderer/autofill/form_autofill_util.cc File chrome/renderer/autofill/form_autofill_util.cc (right): https://codereview.chromium.org/12220070/diff/2001/chrome/renderer/autofill/form_autofill_util.cc#newcode195 chrome/renderer/autofill/form_autofill_util.cc:195: CR_DEFINE_STATIC_LOCAL(WebString, kLabel, ("label")); On 2013/02/11 05:50:30, Ilya Sherman wrote: ...

7 years, 10 months ago (2013-02-11 17:37:51 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abodenha@chromium.org/12220070/7001

7 years, 10 months ago (2013-02-11 17:38:15 UTC) #5

Message was sent while issue was closed.

Change committed as 181751

Expand Messages | Collapse Messages