ppapi/cpp/private/udp_socket_private.cc - Issue 12220050: Provide a way to disable Nagle's algorithm on Pepper TCP sockets.

Unified Diff: ppapi/cpp/private/udp_socket_private.cc

Issue 12220050: Provide a way to disable Nagle's algorithm on Pepper TCP sockets. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Actually export v0.5 interface, and add thunk for it. Fix unit-test and add missing IsConnected che… Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/renderer_host/pepper/pepper_message_filter.h ('K') | « ppapi/cpp/private/tcp_socket_private.cc ('k') | ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c » ('j') | ppapi/proxy/ppapi_messages.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ppapi/cpp/private/udp_socket_private.cc

diff --git a/ppapi/cpp/private/udp_socket_private.cc b/ppapi/cpp/private/udp_socket_private.cc

index c100924fc231d8f29e680da89102237c2852f417..849a887284f1a88997fb2c923c3cc80a56c5d615 100644

--- a/ppapi/cpp/private/udp_socket_private.cc

+++ b/ppapi/cpp/private/udp_socket_private.cc

@@ -53,10 +53,6 @@ int32_t UDPSocketPrivate::SetSocketFeature(PP_UDPSocketFeature_Private name,

int32_t UDPSocketPrivate::Bind(const PP_NetAddress_Private* addr,

const CompletionCallback& callback) {

- if (has_interface<PPB_UDPSocket_Private_0_4>()) {

- return get_interface<PPB_UDPSocket_Private_0_4>()->Bind(

- pp_resource(), addr, callback.pp_completion_callback());

- }

if (has_interface<PPB_UDPSocket_Private_0_3>()) {

return get_interface<PPB_UDPSocket_Private_0_3>()->Bind(

pp_resource(), addr, callback.pp_completion_callback());

@@ -65,12 +61,6 @@ int32_t UDPSocketPrivate::Bind(const PP_NetAddress_Private* addr,

}

bool UDPSocketPrivate::GetBoundAddress(PP_NetAddress_Private* addr) {

- if (has_interface<PPB_UDPSocket_Private_0_4>()) {

- PP_Bool result =

- get_interface<PPB_UDPSocket_Private_0_4>()->GetBoundAddress(

- pp_resource(), addr);

- return PP_ToBool(result);

- }

if (has_interface<PPB_UDPSocket_Private_0_3>()) {

PP_Bool result =

get_interface<PPB_UDPSocket_Private_0_3>()->GetBoundAddress(

@@ -83,10 +73,6 @@ bool UDPSocketPrivate::GetBoundAddress(PP_NetAddress_Private* addr) {

int32_t UDPSocketPrivate::RecvFrom(char* buffer,

int32_t num_bytes,

const CompletionCallback& callback) {

- if (has_interface<PPB_UDPSocket_Private_0_4>()) {

- return get_interface<PPB_UDPSocket_Private_0_4>()->RecvFrom(

- pp_resource(), buffer, num_bytes, callback.pp_completion_callback());

- }

if (has_interface<PPB_UDPSocket_Private_0_3>()) {

return get_interface<PPB_UDPSocket_Private_0_3>()->RecvFrom(

pp_resource(), buffer, num_bytes, callback.pp_completion_callback());

@@ -95,12 +81,6 @@ int32_t UDPSocketPrivate::RecvFrom(char* buffer,

}

bool UDPSocketPrivate::GetRecvFromAddress(PP_NetAddress_Private* addr) {

- if (has_interface<PPB_UDPSocket_Private_0_4>()) {

- PP_Bool result =

- get_interface<PPB_UDPSocket_Private_0_4>()->GetRecvFromAddress(

- pp_resource(), addr);

- return PP_ToBool(result);

- }

if (has_interface<PPB_UDPSocket_Private_0_3>()) {

PP_Bool result =

get_interface<PPB_UDPSocket_Private_0_3>()->GetRecvFromAddress(

@@ -114,11 +94,6 @@ int32_t UDPSocketPrivate::SendTo(const char* buffer,

int32_t num_bytes,

const PP_NetAddress_Private* addr,

const CompletionCallback& callback) {

- if (has_interface<PPB_UDPSocket_Private_0_4>()) {

- return get_interface<PPB_UDPSocket_Private_0_4>()->SendTo(

- pp_resource(), buffer, num_bytes, addr,

- callback.pp_completion_callback());

- }

if (has_interface<PPB_UDPSocket_Private_0_3>()) {

return get_interface<PPB_UDPSocket_Private_0_3>()->SendTo(

pp_resource(), buffer, num_bytes, addr,

@@ -128,8 +103,6 @@ int32_t UDPSocketPrivate::SendTo(const char* buffer,

}

void UDPSocketPrivate::Close() {

- if (has_interface<PPB_UDPSocket_Private_0_4>())

- return get_interface<PPB_UDPSocket_Private_0_4>()->Close(pp_resource());

if (has_interface<PPB_UDPSocket_Private_0_3>())

return get_interface<PPB_UDPSocket_Private_0_3>()->Close(pp_resource());

}