ppapi/shared_impl/private/tcp_socket_private_impl.h - Issue 12220050: Provide a way to disable Nagle's algorithm on Pepper TCP sockets.

Unified Diff: ppapi/shared_impl/private/tcp_socket_private_impl.h

Issue 12220050: Provide a way to disable Nagle's algorithm on Pepper TCP sockets. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Add missing completion callback implementation. Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ppapi/shared_impl/private/tcp_socket_private_impl.h

diff --git a/ppapi/shared_impl/private/tcp_socket_private_impl.h b/ppapi/shared_impl/private/tcp_socket_private_impl.h

index 2792102af790aa7c61729e642a26b4b49cd03a3b..e598374225bf7211361e0d85982ea5ce401e7541 100644

--- a/ppapi/shared_impl/private/tcp_socket_private_impl.h

+++ b/ppapi/shared_impl/private/tcp_socket_private_impl.h

@@ -66,6 +66,8 @@ class PPAPI_SHARED_EXPORT TCPSocketPrivateImpl

int32_t bytes_to_write,

scoped_refptr<TrackedCallback> callback) OVERRIDE;

virtual void Disconnect() OVERRIDE;

+ virtual int32_t SetSocketFeature(PP_TCPSocketFeature_Private name,

yzshen1 2013/02/08 21:51:11 For function declarations and definitions, put eac

Wez 2013/02/10 04:47:02 Done.

+ struct PP_Var value, scoped_refptr<TrackedCallback> callback) OVERRIDE;

yzshen1 2013/02/08 21:51:11 you don't need to have 'struct' here.

Wez 2013/02/10 04:47:02 Done.

// Notifications on operations completion.

void OnConnectCompleted(bool succeeded,

@@ -76,6 +78,7 @@ class PPAPI_SHARED_EXPORT TCPSocketPrivateImpl

const PPB_X509Certificate_Fields& certificate_fields);

void OnReadCompleted(bool succeeded, const std::string& data);

void OnWriteCompleted(bool succeeded, int32_t bytes_written);

+ void OnSetSocketFeatureCompleted(bool succeeded);

// Send functions that need to be implemented differently for the

// proxied and non-proxied derived classes.

@@ -89,6 +92,7 @@ class PPAPI_SHARED_EXPORT TCPSocketPrivateImpl

virtual void SendRead(int32_t bytes_to_read) = 0;

virtual void SendWrite(const std::string& buffer) = 0;

virtual void SendDisconnect() = 0;

+ virtual void SendBoolSocketFeature(int32_t name, bool value) = 0;

protected:

enum ConnectionState {

@@ -117,6 +121,7 @@ class PPAPI_SHARED_EXPORT TCPSocketPrivateImpl

scoped_refptr<TrackedCallback> ssl_handshake_callback_;

scoped_refptr<TrackedCallback> read_callback_;

scoped_refptr<TrackedCallback> write_callback_;

+ scoped_refptr<TrackedCallback> set_feature_callback_;

char* read_buffer_;

int32_t bytes_to_read_;