Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(831)

Unified Diff: ppapi/api/private/ppb_tcp_socket_private.idl

Issue 12220050: Provide a way to disable Nagle's algorithm on Pepper TCP sockets. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add missing completion callback implementation. Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ppapi/api/private/ppb_tcp_socket_private.idl
diff --git a/ppapi/api/private/ppb_tcp_socket_private.idl b/ppapi/api/private/ppb_tcp_socket_private.idl
index 385dee6b4fe526fdf2a3301ac5ff1027f10e6b75..cd21065edf1c3ea2662a7edb7c6f073d6696531a 100644
--- a/ppapi/api/private/ppb_tcp_socket_private.idl
+++ b/ppapi/api/private/ppb_tcp_socket_private.idl
@@ -9,7 +9,18 @@
label Chrome {
M17 = 0.3,
- M20 = 0.4
+ M20 = 0.4,
+ M26 = 0.5
yzshen1 2013/02/08 21:51:11 nit: you probably cannot get it into 26, so this s
Wez 2013/02/10 04:47:02 Done.
+};
+
+[assert_size(4)]
+enum PP_TCPSocketFeature_Private {
+ // Disable coalescing of small writes to make TCP segments, and instead
+ // deliver data immediately. Value type is PP_VARTYPE_BOOL.
+ PP_TCPSOCKETFEATURE_NO_DELAY = 0,
yzshen1 2013/02/08 21:51:11 it seems good to comment that setting this feature
Wez 2013/02/10 04:47:02 Done.
+
+ // Special value used for testing. Guaranteed to fail SetSocketFeature().
+ PP_TCPSOCKETFEATURE_INVALID = -1
yzshen1 2013/02/08 21:51:11 Please order them by their values.
Wez 2013/02/10 04:47:02 Done.
};
/**
@@ -134,4 +145,17 @@ interface PPB_TCPSocket_Private {
* method.
*/
void Disconnect([in] PP_Resource tcp_socket);
+
+ /**
+ * Sets an option on |tcp_socket|. Supported |name| and |value| parameters
+ * are as described for PP_TCPSocketFeature_Private. |callback| will be
+ * invoked with PP_OK if setting the option succeeds, or an error code
+ * otherwise.
+ */
+ [version=0.5]
+ int32_t SetSocketFeature([in] PP_Resource udp_socket,
yzshen1 2013/02/08 21:51:11 - nit: I think SetFeature() is clear enough. - udp
Wez 2013/02/10 04:47:02 SGTM; I'd chosen the function name to match the on
+ [in] PP_TCPSocketFeature_Private name,
+ [in] PP_Var value,
+ [in] PP_CompletionCallback callback);
+
};

Powered by Google App Engine
This is Rietveld 408576698