Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(557)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12220024: Fix CopyFromBackingStore giving back empty SkBitmaps on mac. (Closed)

Created:
7 years, 10 months ago by justinlin
Modified:
7 years, 10 months ago
Reviewers:
Nico, Alpha Left Google
CC:
chromium-reviews, yusukes+watch_chromium.org, jam, penghuang+watch_chromium.org, sail+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, James Su, miu, ncarter (slow)
Visibility:
Public.

Description

Fix CopyFromBackingStore giving back empty SkBitmaps on mac. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180950

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : ifdef #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -22 lines) Patch
M content/browser/renderer_host/compositing_iosurface_mac.mm View 1 2 1 chunk +4 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_browsertest.cc View 1 2 3 3 chunks +57 lines, -21 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
justinlin
hclam@: ptal nico@: ptal for owners thanks
7 years, 10 months ago (2013-02-05 23:53:39 UTC) #1
Alpha Left Google
LGTM.
7 years, 10 months ago (2013-02-06 02:44:03 UTC) #2
Nico
lgtm
7 years, 10 months ago (2013-02-06 04:23:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/justinlin@chromium.org/12220024/1005
7 years, 10 months ago (2013-02-06 04:28:19 UTC) #4
commit-bot: I haz the power
Failed to trigger a try job on win_rel HTTP Error 400: Bad Request
7 years, 10 months ago (2013-02-06 04:51:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/justinlin@chromium.org/12220024/1011
7 years, 10 months ago (2013-02-06 05:04:56 UTC) #6
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 10 months ago (2013-02-06 05:57:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/justinlin@chromium.org/12220024/1011
7 years, 10 months ago (2013-02-06 07:06:20 UTC) #8
commit-bot: I haz the power
7 years, 10 months ago (2013-02-06 09:55:52 UTC) #9
Message was sent while issue was closed. 
Change committed as 180950

Powered by Google App Engine
This is Rietveld 408576698