Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Side by Side Diff: chrome/browser/autocomplete/autocomplete_controller.cc

Issue 12220004: Introduce dynamic ablation of AutocompleteProviders using AC dynamic trials. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/autocomplete/autocomplete_controller.h" 5 #include "chrome/browser/autocomplete/autocomplete_controller.h"
6 6
7 #include <set> 7 #include <set>
8 #include <string> 8 #include <string>
9 9
10 #include "base/command_line.h" 10 #include "base/command_line.h"
11 #include "base/format_macros.h" 11 #include "base/format_macros.h"
12 #include "base/logging.h" 12 #include "base/logging.h"
13 #include "base/metrics/histogram.h" 13 #include "base/metrics/histogram.h"
14 #include "base/string_number_conversions.h" 14 #include "base/string_number_conversions.h"
15 #include "base/stringprintf.h" 15 #include "base/stringprintf.h"
16 #include "base/time.h" 16 #include "base/time.h"
17 #include "chrome/browser/autocomplete/autocomplete_controller_delegate.h" 17 #include "chrome/browser/autocomplete/autocomplete_controller_delegate.h"
18 #include "chrome/browser/autocomplete/autocomplete_field_trial.h"
18 #include "chrome/browser/autocomplete/bookmark_provider.h" 19 #include "chrome/browser/autocomplete/bookmark_provider.h"
19 #include "chrome/browser/autocomplete/builtin_provider.h" 20 #include "chrome/browser/autocomplete/builtin_provider.h"
20 #include "chrome/browser/autocomplete/extension_app_provider.h" 21 #include "chrome/browser/autocomplete/extension_app_provider.h"
21 #include "chrome/browser/autocomplete/history_contents_provider.h" 22 #include "chrome/browser/autocomplete/history_contents_provider.h"
22 #include "chrome/browser/autocomplete/history_quick_provider.h" 23 #include "chrome/browser/autocomplete/history_quick_provider.h"
23 #include "chrome/browser/autocomplete/history_url_provider.h" 24 #include "chrome/browser/autocomplete/history_url_provider.h"
24 #include "chrome/browser/autocomplete/keyword_provider.h" 25 #include "chrome/browser/autocomplete/keyword_provider.h"
25 #include "chrome/browser/autocomplete/search_provider.h" 26 #include "chrome/browser/autocomplete/search_provider.h"
26 #include "chrome/browser/autocomplete/shortcuts_provider.h" 27 #include "chrome/browser/autocomplete/shortcuts_provider.h"
27 #include "chrome/browser/autocomplete/zero_suggest_provider.h" 28 #include "chrome/browser/autocomplete/zero_suggest_provider.h"
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
87 AutocompleteControllerDelegate* delegate, 88 AutocompleteControllerDelegate* delegate,
88 int provider_types) 89 int provider_types)
89 : delegate_(delegate), 90 : delegate_(delegate),
90 keyword_provider_(NULL), 91 keyword_provider_(NULL),
91 search_provider_(NULL), 92 search_provider_(NULL),
92 zero_suggest_provider_(NULL), 93 zero_suggest_provider_(NULL),
93 done_(true), 94 done_(true),
94 in_start_(false), 95 in_start_(false),
95 in_zero_suggest_(false), 96 in_zero_suggest_(false),
96 profile_(profile) { 97 profile_(profile) {
98 // AND with the disabled providers, if any.
99 provider_types &= ~AutocompleteFieldTrial::GetDisabledProviderTypes();
97 bool use_hqp = !!(provider_types & AutocompleteProvider::TYPE_HISTORY_QUICK); 100 bool use_hqp = !!(provider_types & AutocompleteProvider::TYPE_HISTORY_QUICK);
98 // TODO(mrossetti): Permanently modify the HistoryURLProvider to not search 101 // TODO(mrossetti): Permanently modify the HistoryURLProvider to not search
99 // titles once HQP is turned on permanently. 102 // titles once HQP is turned on permanently.
100 // History quick provider can be used on all platforms other than Android. 103 // History quick provider can be used on all platforms other than Android.
101 // TODO(jcivelli): Enable the History Quick Provider and figure out why it 104 // TODO(jcivelli): Enable the History Quick Provider and figure out why it
102 // reports the wrong results for some pages. 105 // reports the wrong results for some pages.
103 #if defined(OS_ANDROID) 106 #if defined(OS_ANDROID)
104 use_hqp = false; 107 use_hqp = false;
105 #endif 108 #endif
106 109
(...skipping 392 matching lines...) Expand 10 before | Expand all | Expand 10 after
499 } 502 }
500 done_ = true; 503 done_ = true;
501 } 504 }
502 505
503 void AutocompleteController::StartExpireTimer() { 506 void AutocompleteController::StartExpireTimer() {
504 if (result_.HasCopiedMatches()) 507 if (result_.HasCopiedMatches())
505 expire_timer_.Start(FROM_HERE, 508 expire_timer_.Start(FROM_HERE,
506 base::TimeDelta::FromMilliseconds(kExpireTimeMS), 509 base::TimeDelta::FromMilliseconds(kExpireTimeMS),
507 this, &AutocompleteController::ExpireCopiedEntries); 510 this, &AutocompleteController::ExpireCopiedEntries);
508 } 511 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698