Added unit tests for the Dart Chrome.* API wrappers.

Added unit tests for the Dart Chrome.* API wrappers, testing the Dart output mode from JSON Schema Compiler.

The physical tests I've added are initial dummies - kalman, please take a look at the *structure* of the test setup. It feels like there is a lot of repetition of test names, but I like using python's unittest framework so it runs as a presubmit check. Any hints?

I have a lot more tests I'd like to add.

Note that there needs to be functionality to disable tests, e.g. there will need to be some tests that will fail from the IDL return value type bug (https://code.google.com/p/chromium/issues/detail?id=170837).

Thanks,

Sasha

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=183709

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=183931

[not at google - send to devlin, 2013-02-20 00:43:01]

This approach seems fine to me, apart from the little bit of shelling-out which
is bound to be problematic.

A suggestion: allow the test to accept a --rebase flag which writes over the
expected values of tests rather than actually running the unit test.

https://codereview.chromium.org/12218151/diff/1/tools/json_schema_compiler/da...
File tools/json_schema_compiler/dart_generator_test.py (right):

https://codereview.chromium.org/12218151/diff/1/tools/json_schema_compiler/da...
tools/json_schema_compiler/dart_generator_test.py:46: 'diff %(diff_flags)s
%(expected_output_file)s -']
I don't think we can assume that these will work - specifically in a windows
environment (p.s. the paths above won't work either up at ./dart_test/).

Besides which, calling out to shell is pretty crazy. You could make some pretty
minor changes to compiler.py to make it callable from here natively, you can
implement tail pretty trivially, and you can let self.assertEq handle the
diffing*.

* not sure about that. Maybe.

[benwells, 2013-02-20 01:52:21]

On 2013/02/20 00:43:01, kalman wrote:
> This approach seems fine to me, apart from the little bit of shelling-out
which
> is bound to be problematic.
> 
> A suggestion: allow the test to accept a --rebase flag which writes over the
> expected values of tests rather than actually running the unit test.

+1 to --rebase

> 
>
https://codereview.chromium.org/12218151/diff/1/tools/json_schema_compiler/da...
> File tools/json_schema_compiler/dart_generator_test.py (right):
> 
>
https://codereview.chromium.org/12218151/diff/1/tools/json_schema_compiler/da...
> tools/json_schema_compiler/dart_generator_test.py:46: 'diff %(diff_flags)s
> %(expected_output_file)s -']
> I don't think we can assume that these will work - specifically in a windows
> environment (p.s. the paths above won't work either up at ./dart_test/).
> 
> Besides which, calling out to shell is pretty crazy. You could make some
pretty
> minor changes to compiler.py to make it callable from here natively, you can
> implement tail pretty trivially, and you can let self.assertEq handle the
> diffing*.
> 
> * not sure about that. Maybe.

[sashab, 2013-02-20 02:54:23]

Added --rebase as suggested, which prompts the user for a confirmation. Also
removed calls to os.system() by slightly refactoring compiler.py.

https://codereview.chromium.org/12218151/diff/1/tools/json_schema_compiler/da...
File tools/json_schema_compiler/dart_generator_test.py (right):

https://codereview.chromium.org/12218151/diff/1/tools/json_schema_compiler/da...
tools/json_schema_compiler/dart_generator_test.py:46: 'diff %(diff_flags)s
%(expected_output_file)s -']
On 2013/02/20 00:43:01, kalman wrote:
> I don't think we can assume that these will work - specifically in a windows
> environment (p.s. the paths above won't work either up at ./dart_test/).
> 
> Besides which, calling out to shell is pretty crazy. You could make some
pretty
> minor changes to compiler.py to make it callable from here natively, you can
> implement tail pretty trivially, and you can let self.assertEq handle the
> diffing*.
> 
> * not sure about that. Maybe.

Done.

[not at google - send to devlin, 2013-02-20 03:02:33]

lgtm, a couple of style things to fix up now that compiler.py is used as a
library.

https://codereview.chromium.org/12218151/diff/6001/tools/json_schema_compiler...
File tools/json_schema_compiler/compiler.py (right):

https://codereview.chromium.org/12218151/diff/6001/tools/json_schema_compiler...
tools/json_schema_compiler/compiler.py:35: def load_schema(schema):
_LoadSchema

https://codereview.chromium.org/12218151/diff/6001/tools/json_schema_compiler...
tools/json_schema_compiler/compiler.py:51: def generate_schema(generator,
GenerateSchema

https://codereview.chromium.org/12218151/diff/6001/tools/json_schema_compiler...
tools/json_schema_compiler/compiler.py:196: print
generate_schema(opts.generator, filenames, opts.root, opts.destdir,
nit: print(foo) not print foo.

https://codereview.chromium.org/12218151/diff/6001/tools/json_schema_compiler...
File tools/json_schema_compiler/dart_generator_test.py (right):

https://codereview.chromium.org/12218151/diff/6001/tools/json_schema_compiler...
tools/json_schema_compiler/dart_generator_test.py:21: def _RunTest(self,
test_filename, tests_dir='dart_test'):
this tests_dir thing is never used as a parameter - and if you do need to switch
it to something, I'd expect an argument to the unittest would be a better way to
do it (like with REBASE_MODE).

https://codereview.chromium.org/12218151/diff/6001/tools/json_schema_compiler...
tools/json_schema_compiler/dart_generator_test.py:39: expected_output =
open('%s.dart' % file_rel).read()
Should be closing files here, this function is run lots of times.

with f as open('%s.dart' % file_rel):
  expected_output = f.read()

https://codereview.chromium.org/12218151/diff/6001/tools/json_schema_compiler...
tools/json_schema_compiler/dart_generator_test.py:82: cont = raw_input("Are you
sure you wish to continue? Y/[N] ")
I don't think a confirmation is necessary. It's an explicit action to say
--rebase, and if something does screw up then there's always git reset.

[sashab, 2013-02-20 03:26:18]

Style & structure fixes as requested. User confirmation removed for --rebase.

https://codereview.chromium.org/12218151/diff/6001/tools/json_schema_compiler...
File tools/json_schema_compiler/compiler.py (right):

https://codereview.chromium.org/12218151/diff/6001/tools/json_schema_compiler...
tools/json_schema_compiler/compiler.py:35: def load_schema(schema):
On 2013/02/20 03:02:33, kalman wrote:
> _LoadSchema

Done.

https://codereview.chromium.org/12218151/diff/6001/tools/json_schema_compiler...
tools/json_schema_compiler/compiler.py:51: def generate_schema(generator,
On 2013/02/20 03:02:33, kalman wrote:
> GenerateSchema

Done.

https://codereview.chromium.org/12218151/diff/6001/tools/json_schema_compiler...
tools/json_schema_compiler/compiler.py:196: print
generate_schema(opts.generator, filenames, opts.root, opts.destdir,
On 2013/02/20 03:02:33, kalman wrote:
> nit: print(foo) not print foo.

Done. Also fixed logic a bit.

https://codereview.chromium.org/12218151/diff/6001/tools/json_schema_compiler...
File tools/json_schema_compiler/dart_generator_test.py (right):

https://codereview.chromium.org/12218151/diff/6001/tools/json_schema_compiler...
tools/json_schema_compiler/dart_generator_test.py:21: def _RunTest(self,
test_filename, tests_dir='dart_test'):
On 2013/02/20 03:02:33, kalman wrote:
> this tests_dir thing is never used as a parameter - and if you do need to
switch
> it to something, I'd expect an argument to the unittest would be a better way
to
> do it (like with REBASE_MODE).

Done.

https://codereview.chromium.org/12218151/diff/6001/tools/json_schema_compiler...
tools/json_schema_compiler/dart_generator_test.py:39: expected_output =
open('%s.dart' % file_rel).read()
On 2013/02/20 03:02:33, kalman wrote:
> Should be closing files here, this function is run lots of times.
> 
> with f as open('%s.dart' % file_rel):
>   expected_output = f.read()

Done.

https://codereview.chromium.org/12218151/diff/6001/tools/json_schema_compiler...
tools/json_schema_compiler/dart_generator_test.py:82: cont = raw_input("Are you
sure you wish to continue? Y/[N] ")
On 2013/02/20 03:02:33, kalman wrote:
> I don't think a confirmation is necessary. It's an explicit action to say
> --rebase, and if something does screw up then there's always git reset.

Done. Still printed a message to be clear.

[commit-bot: I haz the power, 2013-02-20 23:23:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sashab@chromium.org/12218151/16003

[commit-bot: I haz the power, 2013-02-20 23:23:51]

Presubmit check for 12218151-16003 failed and returned exit status 1.

INFO:root:Found 20 file(s).

testChoices (__main__.ModelTest) ... ok
testDescription (__main__.ModelTest) ... ok
testHasFunctions (__main__.ModelTest) ... ok
testHasProperties (__main__.ModelTest) ... ok
testHasTypes (__main__.ModelTest) ... ok
testNamespaces (__main__.ModelTest) ... ok
testProperties (__main__.ModelTest) ... ok
testPropertyNotImplemented (__main__.ModelTest) ... ok
testPropertyUnixName (__main__.ModelTest) ... ok
testUnixName (__main__.ModelTest) ... ok

----------------------------------------------------------------------
Ran 10 tests in 0.655s

OK
testArrayAsType (__main__.CppTypeGeneratorTest) ... ok
testGenerateIncludesAndForwardDeclarations (__main__.CppTypeGeneratorTest) ...
ok
testGenerateIncludesAndForwardDeclarationsDependencies
(__main__.CppTypeGeneratorTest) ... ok
testGetCppTypeArray (__main__.CppTypeGeneratorTest) ... ok
testGetCppTypeIncludedRef (__main__.CppTypeGeneratorTest) ... ok
testGetCppTypeLocalRef (__main__.CppTypeGeneratorTest) ... ok
testGetCppTypeSimple (__main__.CppTypeGeneratorTest) ... ok
testGetCppTypeWithPadForGeneric (__main__.CppTypeGeneratorTest) ... ok
testStringAsType (__main__.CppTypeGeneratorTest) ... ok

----------------------------------------------------------------------
Ran 9 tests in 1.057s

OK
testClassname (__main__.CppUtilTest) ... ok
testNamespaceDeclaration (__main__.CppUtilTest) ... ok

----------------------------------------------------------------------
Ran 2 tests in 0.000s

OK
testBasicEvent (__main__.DartTest) ... ERROR
testBasicFunction (__main__.DartTest) ... ERROR
testBasicType (__main__.DartTest) ... ERROR
testComments (__main__.DartTest) ... ERROR
testComplexType (__main__.DartTest) ... ERROR
testEmptyNamespace (__main__.DartTest) ... ERROR
testEmptyType (__main__.DartTest) ... ERROR
testOpratableType (__main__.DartTest) ... ERROR
testTags (__main__.DartTest) ... ERROR

======================================================================
ERROR: testBasicEvent (__main__.DartTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "./dart_generator_test.py", line 54, in testBasicEvent
    self._RunTest('basic_event')
  File "./dart_generator_test.py", line 46, in _RunTest
    self.assertListEqual([l for l in expected_output.split('\n') if l],
AttributeError: 'DartTest' object has no attribute 'assertListEqual'

======================================================================
ERROR: testBasicFunction (__main__.DartTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "./dart_generator_test.py", line 57, in testBasicFunction
    self._RunTest('basic_function')
  File "./dart_generator_test.py", line 46, in _RunTest
    self.assertListEqual([l for l in expected_output.split('\n') if l],
AttributeError: 'DartTest' object has no attribute 'assertListEqual'

======================================================================
ERROR: testBasicType (__main__.DartTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "./dart_generator_test.py", line 60, in testBasicType
    self._RunTest('basic_type')
  File "./dart_generator_test.py", line 46, in _RunTest
    self.assertListEqual([l for l in expected_output.split('\n') if l],
AttributeError: 'DartTest' object has no attribute 'assertListEqual'

======================================================================
ERROR: testComments (__main__.DartTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "./dart_generator_test.py", line 63, in testComments
    self._RunTest('comments')
  File "./dart_generator_test.py", line 46, in _RunTest
    self.assertListEqual([l for l in expected_output.split('\n') if l],
AttributeError: 'DartTest' object has no attribute 'assertListEqual'

======================================================================
ERROR: testComplexType (__main__.DartTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "./dart_generator_test.py", line 66, in testComplexType
    self._RunTest('complex_type')
  File "./dart_generator_test.py", line 46, in _RunTest
    self.assertListEqual([l for l in expected_output.split('\n') if l],
AttributeError: 'DartTest' object has no attribute 'assertListEqual'

======================================================================
ERROR: testEmptyNamespace (__main__.DartTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "./dart_generator_test.py", line 69, in testEmptyNamespace
    self._RunTest('empty_namespace')
  File "./dart_generator_test.py", line 46, in _RunTest
    self.assertListEqual([l for l in expected_output.split('\n') if l],
AttributeError: 'DartTest' object has no attribute 'assertListEqual'

======================================================================
ERROR: testEmptyType (__main__.DartTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "./dart_generator_test.py", line 72, in testEmptyType
    self._RunTest('empty_type')
  File "./dart_generator_test.py", line 46, in _RunTest
    self.assertListEqual([l for l in expected_output.split('\n') if l],
AttributeError: 'DartTest' object has no attribute 'assertListEqual'

======================================================================
ERROR: testOpratableType (__main__.DartTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "./dart_generator_test.py", line 75, in testOpratableType
    self._RunTest('operatable_type')
  File "./dart_generator_test.py", line 46, in _RunTest
    self.assertListEqual([l for l in expected_output.split('\n') if l],
AttributeError: 'DartTest' object has no attribute 'assertListEqual'

======================================================================
ERROR: testTags (__main__.DartTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "./dart_generator_test.py", line 78, in testTags
    self._RunTest('tags')
  File "./dart_generator_test.py", line 46, in _RunTest
    self.assertListEqual([l for l in expected_output.split('\n') if l],
AttributeError: 'DartTest' object has no attribute 'assertListEqual'

----------------------------------------------------------------------
Ran 9 tests in 1.157s

FAILED (errors=9)
testNocompile (__main__.JsonSchemaUnittest) ... ok

----------------------------------------------------------------------
Ran 1 test in 0.006s

OK
testJsFunctionNameToClassName (__main__.SchemaUtilTest) ... ok
testStripNamespace (__main__.SchemaUtilTest) ... ok

----------------------------------------------------------------------
Ran 2 tests in 0.000s

OK
testAppend (__main__.CodeTest) ... ok
testBlock (__main__.CodeTest) ... ok
testComment (__main__.CodeTest) ... ok
testCommentWithSpecialCharacters (__main__.CodeTest) ... ok
testConcat (__main__.CodeTest) ... ok
testConcatErrors (__main__.CodeTest) ... ok
testIsEmpty (__main__.CodeTest) ... ok
testSubstitute (__main__.CodeTest) ... ok
testSubstituteErrors (__main__.CodeTest) ... ok

----------------------------------------------------------------------
Ran 9 tests in 0.000s

OK
testArrayOfCallbacks (__main__.IdlSchemaTest) ... ok
testCallbackComment (__main__.IdlSchemaTest) ... ok
testCallbackWithArrayArgument (__main__.IdlSchemaTest) ... ok
testEnum (__main__.IdlSchemaTest) ... ok
testFunctionComment (__main__.IdlSchemaTest) ... ok
testInternalNamespace (__main__.IdlSchemaTest) ... ok
testLegalValues (__main__.IdlSchemaTest) ... ok
testMemberOrdering (__main__.IdlSchemaTest) ... ok
testNoCompile (__main__.IdlSchemaTest) ... ok
testReservedWords (__main__.IdlSchemaTest) ... ok
testSimpleCallbacks (__main__.IdlSchemaTest) ... ok

----------------------------------------------------------------------
Ran 11 tests in 1.716s

OK
Running presubmit commit checks ...
Running /b/commit-queue/workdir/chromium/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/tools/json_schema_compiler/PRESUBMIT.py
Running ./model_test.py
Running ./cpp_type_generator_test.py
Running ./cpp_util_test.py
Running ./dart_generator_test.py
Running ./json_schema_test.py
Running ./schema_util_test.py
Running ./code_test.py
Running ./idl_schema_test.py

** Presubmit Messages **
If this change has an associated bug, add BUG=[bug number].

** Presubmit ERRORS **
./dart_generator_test.py failed!
Command ./dart_generator_test.py --verbose returned non-zero exit status 1 in
/b/commit-queue/workdir/chromium/tools/json_schema_compiler

Presubmit checks took 7.1s to calculate.

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

[commit-bot: I haz the power, 2013-02-20 23:40:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sashab@chromium.org/12218151/19002

[commit-bot: I haz the power, 2013-02-20 23:47:35]

Failed to trigger a try job on linux_clang
HTTP Error 400: Bad Request

[commit-bot: I haz the power, 2013-02-20 23:47:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sashab@chromium.org/12218151/9004

[commit-bot: I haz the power, 2013-02-21 01:49:08]

Change committed as 183709

[commit-bot: I haz the power, 2013-02-21 22:28:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sashab@chromium.org/12218151/6025

[commit-bot: I haz the power, 2013-02-22 00:27:23]

Change committed as 183931