Only register component-updated Flash if it is newer than the bundled one.

Only register component-updated Flash if it is newer than the bundled one.

Previously, if the component-updated Flash was the same version as the
bundled one, the component-updated one took precedence.

BUG=None
TEST=None


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182251

[yzshen1, 2013-02-12 21:45:43]

Hi, Carlos.

Would you please take a look? Thanks!

[cpu_(ooo_6.6-7.5), 2013-02-12 22:18:17]

https://codereview.chromium.org/12218125/diff/1/chrome/browser/component_upda...
File chrome/browser/component_updater/pepper_flash_component_installer.cc
(right):

https://codereview.chromium.org/12218125/diff/1/chrome/browser/component_upda...
chrome/browser/component_updater/pepper_flash_component_installer.cc:195:
return;
why not

registered_version.IsOlderThan(version)  ?

[yzshen1, 2013-02-12 22:27:19]

https://codereview.chromium.org/12218125/diff/1/chrome/browser/component_upda...
File chrome/browser/component_updater/pepper_flash_component_installer.cc
(right):

https://codereview.chromium.org/12218125/diff/1/chrome/browser/component_upda...
chrome/browser/component_updater/pepper_flash_component_installer.cc:195:
return;
On 2013/02/12 22:18:17, cpu wrote:
> why not
> 
> registered_version.IsOlderThan(version)  ?
That is because IsOlderThan() receives a string, so I have to do
registered_version.IsOlderThan(version.GetString()). And IsOlderThan() will
convert that string back to a Version object.

It seems cleaner using CompareTo(), and with the comment I think the readability
is okay.

[cpu_(ooo_6.6-7.5), 2013-02-13 03:04:01]

lgtm

[commit-bot: I haz the power, 2013-02-13 07:17:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yzshen@chromium.org/12218125/1

[commit-bot: I haz the power, 2013-02-13 07:41:58]

Retried try job too often on linux_chromeos for step(s) aura_unittests,
browser_tests, content_browsertests, ppapi_unittests, unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2013-02-13 08:09:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yzshen@chromium.org/12218125/1

[commit-bot: I haz the power, 2013-02-13 18:13:56]

Change committed as 182251