Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Issue 12218117: Fixed location and name of temporarily files. (Closed)

Created:
7 years, 10 months ago by Vitaly Buka (NO REVIEWS)
Modified:
7 years, 10 months ago
Reviewers:
gene
CC:
chromium-reviews
Visibility:
Public.

Description

Fixed location and name of temporarily files. Don't append XPS extension. Use empty file created by CreateTemporaryFileInDir. Use AppData subdir same as ProgramFiles subdir. Delete leaked files. BUG=172554 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182068

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -8 lines) Patch
M cloud_print/virtual_driver/win/port_monitor/port_monitor.cc View 3 chunks +30 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Vitaly Buka (NO REVIEWS)
7 years, 10 months ago (2013-02-12 09:42:46 UTC) #1
gene
lgtm
7 years, 10 months ago (2013-02-12 19:24:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/12218117/5006
7 years, 10 months ago (2013-02-12 19:32:59 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) content_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=110881
7 years, 10 months ago (2013-02-12 20:47:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/12218117/5006
7 years, 10 months ago (2013-02-12 20:58:26 UTC) #5
commit-bot: I haz the power
7 years, 10 months ago (2013-02-13 00:12:27 UTC) #6
Message was sent while issue was closed.
Change committed as 182068

Powered by Google App Engine
This is Rietveld 408576698