Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 12218112: Android: Check for Oracle Java when running build/android/envsetup.sh. (Closed)

Created:
7 years, 10 months ago by Lei Zhang
Modified:
7 years, 10 months ago
Reviewers:
Yaron
CC:
chromium-reviews, klundberg+watch_chromium.org, frankf+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org
Visibility:
Public.

Description

Android: Check for Oracle Java when running build/android/envsetup.sh. NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182010

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M build/android/envsetup.sh View 1 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Lei Zhang
Today's struggle in building Android unit tests occurred because I had the wrong Java in ...
7 years, 10 months ago (2013-02-12 03:06:57 UTC) #1
Yaron
https://codereview.chromium.org/12218112/diff/1/build/android/envsetup.sh File build/android/envsetup.sh (right): https://codereview.chromium.org/12218112/diff/1/build/android/envsetup.sh#newcode109 build/android/envsetup.sh:109: echo "Please check and make sure you are using ...
7 years, 10 months ago (2013-02-12 18:50:35 UTC) #2
Lei Zhang
https://codereview.chromium.org/12218112/diff/1/build/android/envsetup.sh File build/android/envsetup.sh (right): https://codereview.chromium.org/12218112/diff/1/build/android/envsetup.sh#newcode109 build/android/envsetup.sh:109: echo "Please check and make sure you are using ...
7 years, 10 months ago (2013-02-12 18:58:01 UTC) #3
Yaron
lgtm
7 years, 10 months ago (2013-02-12 20:02:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/12218112/3001
7 years, 10 months ago (2013-02-12 21:07:10 UTC) #5
commit-bot: I haz the power
7 years, 10 months ago (2013-02-12 21:12:58 UTC) #6
Message was sent while issue was closed.
Change committed as 182010

Powered by Google App Engine
This is Rietveld 408576698