Issue 12218093: Do not cache the tab background if a tab background was autogenerated by a theme

Issue 12218093: Do not cache the tab background if a tab background was autogenerated by a theme (Closed)

Created:
7 years, 10 months ago by pkotwicz

Modified:
7 years, 10 months ago

Reviewers:
sky

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Do not cache the tab background if a tab background was autogenerated by a theme BUG=175426 Test=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182095

Patch Set 6 : #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -1 line)			Patch
	M	chrome/browser/ui/views/tabs/tab.cc	View	1 2 3 4 5	1 chunk	+13 lines, -1 line	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

sky

https://codereview.chromium.org/12218093/diff/2001/chrome/browser/ui/views/tabs/tab.cc File chrome/browser/ui/views/tabs/tab.cc (right): https://codereview.chromium.org/12218093/diff/2001/chrome/browser/ui/views/tabs/tab.cc#newcode1161 chrome/browser/ui/views/tabs/tab.cc:1161: tab_base_id = 0; Is 0 known to be ignored? ...

7 years, 10 months ago (2013-02-11 21:21:54 UTC) #2

sky

LGTM https://codereview.chromium.org/12218093/diff/4/chrome/browser/ui/views/tabs/tab.cc File chrome/browser/ui/views/tabs/tab.cc (right): https://codereview.chromium.org/12218093/diff/4/chrome/browser/ui/views/tabs/tab.cc#newcode1182 chrome/browser/ui/views/tabs/tab.cc:1182: bool theme_provided_image = theme_provider->HasCustomImage(tab_id) || const

7 years, 10 months ago (2013-02-12 03:14:21 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/12218093/5002

7 years, 10 months ago (2013-02-12 15:26:29 UTC) #5

commit-bot: I haz the power

Retried try job too often on mac_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=98790

7 years, 10 months ago (2013-02-12 16:28:29 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/12218093/13001

7 years, 10 months ago (2013-02-12 23:22:05 UTC) #7

Message was sent while issue was closed.

Change committed as 182095

Expand Messages | Collapse Messages