Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 12218088: gpu: Change qualcomm work-around. (Closed)

Created:
7 years, 10 months ago by epenner
Modified:
7 years, 10 months ago
Reviewers:
apatrick_chromium
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

gpu: Change qualcomm work-around. The only way to keep image_preserved disabled was to use a glFinish after EGL image creation. This is fine if we only create EGL images on the upload thread, but we might start doing this on either thread. This alternative work around just doesn't use image- preserve. The performance benefit wasn't large on Qualcomm anyway. No-try for Android only change. NOTRY=true BUG=175272 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181819

Patch Set 1 #

Patch Set 2 : Add img too. #

Patch Set 3 : Tweak #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -78 lines) Patch
M ui/gl/async_pixel_transfer_delegate_android.cc View 1 2 13 chunks +60 lines, -78 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
epenner
Ptal
7 years, 10 months ago (2013-02-09 03:23:31 UTC) #1
epenner
Minor tweaks. Ptal.
7 years, 10 months ago (2013-02-11 19:21:35 UTC) #2
apatrick_chromium
lgtm
7 years, 10 months ago (2013-02-11 19:48:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/epenner@chromium.org/12218088/5001
7 years, 10 months ago (2013-02-11 22:32:38 UTC) #4
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
7 years, 10 months ago (2013-02-12 01:28:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/epenner@chromium.org/12218088/5001
7 years, 10 months ago (2013-02-12 01:55:44 UTC) #6
commit-bot: I haz the power
7 years, 10 months ago (2013-02-12 01:59:50 UTC) #7
Message was sent while issue was closed.
Change committed as 181819

Powered by Google App Engine
This is Rietveld 408576698