- Remove redundant type parameters for internal data.

vm/object.h

Index: vm/object.h
===================================================================
--- vm/object.h	(revision 18158)
+++ vm/object.h	(working copy)
@@ -4668,9 +4668,6 @@
   RawObject* RemoveLast() const;
 
   virtual RawAbstractTypeArguments* GetTypeArguments() const {

[siva, 2013/02/08 23:13:34]

Should we assert here that
Array::Handle(data()).GetTypeArguments()
is null now.
(we don't want some random type being set here).

[Ivan Posva, 2013/02/08 23:27:32]

Actually we don't and shouldn't care about the type being set on the backing
store.

[siva, 2013/02/08 23:32:28]

I disagree, if the data is irrelevant then that field should not be there (have
a different representation for the backing store which is more tedious) or if we
have it then make it a sane value so that we know what to expect when we are
debugging heap trashes or some similar nasty bug.


On 2013/02/08 23:27:32, Ivan Posva wrote:

-    ASSERT(AbstractTypeArguments::AreEqual(
-        AbstractTypeArguments::Handle(Array::Handle(data()).GetTypeArguments()),
-        AbstractTypeArguments::Handle(raw_ptr()->type_arguments_)));
     return raw_ptr()->type_arguments_;
   }
   virtual void SetTypeArguments(const AbstractTypeArguments& value) const {