Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Issue 12218070: Make views_unittests build on Win64 (Closed)

Created:
7 years, 10 months ago by jschuh
Modified:
7 years, 10 months ago
Reviewers:
tkent
CC:
chromium-reviews, darin-cc_chromium.org
Visibility:
Public.

Description

Make views_unittests build on Win64 Just c4267 build suppressions. BUG=166496 BUG=167187 TBR=tkent@chromium.org R=tkent@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181451

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M webkit/support/webkit_support.gypi View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jschuh@chromium.org/12218070/1
7 years, 10 months ago (2013-02-08 05:32:09 UTC) #1
tkent
LGTM though fixing the warnings is better than suppressing the warnings.
7 years, 10 months ago (2013-02-08 05:34:44 UTC) #2
jschuh
On 2013/02/08 05:34:44, Kent Tamura wrote: > LGTM though fixing the warnings is better than ...
7 years, 10 months ago (2013-02-08 05:38:57 UTC) #3
commit-bot: I haz the power
7 years, 10 months ago (2013-02-08 07:39:42 UTC) #4
Message was sent while issue was closed.
Change committed as 181451

Powered by Google App Engine
This is Rietveld 408576698