CreateShortcutIcon on Linux now creates icons at all available resolutions, not

CreateShortcutIcon on Linux now creates icons at all available resolutions, not
just 32x32.

Note: This is currently not used on Linux, since the Create Shortcuts dialog
builds its own icons. This is in preparation for migrating the icon creation
code.

BUG=175033
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181884

[jeremya, 2013-02-08 04:51:13]

lgtm

[Matt Giuca, 2013-02-08 05:02:15]

Hi Scott,

Adding you as a reviewer for OWNERS. CL should have no functional effect; it's
just paving the way for Linux to use the generic icon installer.

[sky, 2013-02-11 17:45:27]

https://codereview.chromium.org/12218069/diff/4001/chrome/browser/shell_integ...
File chrome/browser/shell_integration_linux.cc (right):

https://codereview.chromium.org/12218069/diff/4001/chrome/browser/shell_integ...
chrome/browser/shell_integration_linux.cc:95: {
{ on previous line

https://codereview.chromium.org/12218069/diff/4001/chrome/browser/shell_integ...
chrome/browser/shell_integration_linux.cc:97:
gfx::PNGCodec::EncodeBGRASkBitmap(bitmap, false, &png_data);
You're not checking return value here. Worse yet, because png_data is declared
outside the loop weird things may happen if this returns false. png_data should
be moved inside the loop.

[Matt Giuca, 2013-02-11 23:58:56]

Done. Thanks for the review.

https://codereview.chromium.org/12218069/diff/4001/chrome/browser/shell_integ...
File chrome/browser/shell_integration_linux.cc (right):

https://codereview.chromium.org/12218069/diff/4001/chrome/browser/shell_integ...
chrome/browser/shell_integration_linux.cc:95: {
On 2013/02/11 17:45:27, sky wrote:
> { on previous line

Done.

https://codereview.chromium.org/12218069/diff/4001/chrome/browser/shell_integ...
chrome/browser/shell_integration_linux.cc:97:
gfx::PNGCodec::EncodeBGRASkBitmap(bitmap, false, &png_data);
On 2013/02/11 17:45:27, sky wrote:
> You're not checking return value here. Worse yet, because png_data is declared
> outside the loop weird things may happen if this returns false. png_data
should
> be moved inside the loop.

Good catch. Fixed both.

While we're checking return values, I've also checked the return value and exit
code of LaunchXdgUtility and put in a warning for both failures.

[sky, 2013-02-12 01:03:38]

LGTM

[commit-bot: I haz the power, 2013-02-12 01:16:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mgiuca@chromium.org/12218069/8001

[commit-bot: I haz the power, 2013-02-12 06:34:39]

Change committed as 181884