Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 12218056: Added more default expectations to MockDBusThreadManager. (Closed)

Created:
7 years, 10 months ago by Joao da Silva
Modified:
7 years, 10 months ago
Reviewers:
satorux1
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Visibility:
Public.

Description

Added more default expectations to MockDBusThreadManager. This prevents warnings when using a MockDBusThreadManager in a browser_test. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181449

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -6 lines) Patch
M chromeos/dbus/mock_dbus_thread_manager.cc View 4 chunks +11 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Joao da Silva
This fixes more warnings that started popping up today. I'm not sure if adding expectations ...
7 years, 10 months ago (2013-02-07 16:53:00 UTC) #1
satorux1
LGTM. thanks!
7 years, 10 months ago (2013-02-08 02:21:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/12218056/1
7 years, 10 months ago (2013-02-08 06:07:18 UTC) #3
commit-bot: I haz the power
7 years, 10 months ago (2013-02-08 07:38:20 UTC) #4
Message was sent while issue was closed.
Change committed as 181449

Powered by Google App Engine
This is Rietveld 408576698