Attach ImeAdapter as soon as native side is ready

Attach ImeAdapter as soon as native side is ready

There are code paths that can directly call ImeAdapter.sendKeyEvent
which rely on having ImeAdapter attached as soon possible instead of
lazily from ContentViewCore.dispatchKeyEvent.

BUG=171485
Android only change. Ran through android trybots.
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181190

[boliu, 2013-02-06 08:03:21]

This fixes testOnUnhandledKeyEvent cts test

[joth, 2013-02-06 17:58:38]

+aruslan as, iirc, he made some changes in this area before too.

[aruslan, 2013-02-06 18:03:22]

Looks clean, but Yusuf and Aurimas should know more.

[Yusuf, 2013-02-06 18:16:47]

lgtm

My only worry would be hardware keyboard trouble since we only use the
dispatchKeyEvent path for that. Bo I know you have done your share of testing
IME and keyboard, but would you mind checking this by itself on a hardware
keyboard before committing?



On 2013/02/06 18:03:22, aruslan wrote:
> Looks clean, but Yusuf and Aurimas should know more.

[boliu, 2013-02-06 18:27:13]

On 2013/02/06 18:16:47, Yusuf wrote:
> lgtm
> 
> My only worry would be hardware keyboard trouble since we only use the
> dispatchKeyEvent path for that. Bo I know you have done your share of testing
> IME and keyboard, but would you mind checking this by itself on a hardware
> keyboard before committing?

Nothing broken with a textarea in webpage.

[joth, 2013-02-06 22:12:21]

lgtm

[commit-bot: I haz the power, 2013-02-06 22:24:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/boliu@chromium.org/12218029/1

[commit-bot: I haz the power, 2013-02-07 04:10:51]

Change committed as 181190