Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(571)

Issue 12217164: Add restrictions for min and max width of the left nav in Files.app to avoid breaking layout. (Closed)

Created:
7 years, 10 months ago by mtomasz
Modified:
7 years, 10 months ago
Reviewers:
yoshiki
CC:
chromium-reviews, rginda+watch_chromium.org, arv+watch_chromium.org
Visibility:
Public.

Description

Add restrictions for min and max width of the left nav in Files.app to avoid breaking layout. Previously, it was easy to resize the nav, so the file list would disappear. We shouldn't let users break the ui. TEST=Follow the bug's repro steps. BUG=175958 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182196

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/browser/resources/file_manager/css/file_manager.css View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
mtomasz
@yoshiki: PTAL.
7 years, 10 months ago (2013-02-13 07:50:50 UTC) #1
yoshiki
lgtm
7 years, 10 months ago (2013-02-13 07:57:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/12217164/1
7 years, 10 months ago (2013-02-13 08:00:05 UTC) #3
commit-bot: I haz the power
7 years, 10 months ago (2013-02-13 11:53:29 UTC) #4
Message was sent while issue was closed.
Change committed as 182196

Powered by Google App Engine
This is Rietveld 408576698