Fixing the double border around rounded menus.

Fixing the double border around rounded menus.


BUG=175605
TEST=visual


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182131

[Mr4D (OOO till 08-26), 2013-02-12 22:29:19]

When the new theme for windows was added, the "shadow border", which is drawn
for Cros, was left in place. As such we got two borders drawn -> thick border.

There are two possibilities:
1. Use the new theme - which would mean that there would be no shadow more for
the menu in ChromeOS (since on windows the shadow gets generated by windows).
2. Use the old theme for ChromeOS - which would lead to different code for
ChromeOS vs. Windows, but it would keep the shadow for ChromeOS accordingly.
3. Add a new shadow type which would only draw the new shadow outline and use
the new theme border.

Sgabriel said that he wants to keep ChromeOS as it is - not following the
Windows changes. I was therefore keeping the border code for ChromeOS as it
is/was.

Please have a look!

[sky, 2013-02-13 00:06:53]

https://codereview.chromium.org/12217146/diff/4001/ui/views/controls/menu/men...
File ui/views/controls/menu/menu_scroll_view_container.cc (right):

https://codereview.chromium.org/12217146/diff/4001/ui/views/controls/menu/men...
ui/views/controls/menu/menu_scroll_view_container.cc:273: #if
defined(OS_CHROMEOS)
This should be based on whether the NativeTheme is NativeThemeAura, not
chromeos. Can we set the corner_radius to 0 in menuconfigviews and have that
imply an empty border?

[Mr4D (OOO till 08-26), 2013-02-13 00:34:15]

Please have another look!

https://codereview.chromium.org/12217146/diff/4001/ui/views/controls/menu/men...
File ui/views/controls/menu/menu_scroll_view_container.cc (right):

https://codereview.chromium.org/12217146/diff/4001/ui/views/controls/menu/men...
ui/views/controls/menu/menu_scroll_view_container.cc:273: #if
defined(OS_CHROMEOS)
Okay, I looked at the NativeThemeAura as requested. For the corner_radius of 0:
Windows has currently a corner_radius of 0 because of the shadow which cannot
have round edges. So that is not a good way to detect this case.

[sky, 2013-02-13 00:35:46]

LGTM

[commit-bot: I haz the power, 2013-02-13 01:29:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/skuhne@chromium.org/12217146/8001

[commit-bot: I haz the power, 2013-02-13 06:06:54]

Change committed as 182131