Add accessibility support for reading date and time on ash tray.

Add accessibility support for reading date and time on ash tray.


BUG=174479
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181862

[Jun Mukai, 2013-02-12 01:04:03]

https://codereview.chromium.org/12217121/diff/1/ash/system/date/date_view.cc
File ash/system/date/date_view.cc (right):

https://codereview.chromium.org/12217121/diff/1/ash/system/date/date_view.cc#...
ash/system/date/date_view.cc:143: now, base::k12HourClock, base:: kKeepAmPm));
Is there some reason to be comma-separated rather than IDS_ASH_STATUS_TRAY_DATE?
Sometimes people want to hear in their native language?
# I don't know which is better actually, probably good to ask dmazzoni

[jennyz, 2013-02-12 01:07:38]

https://codereview.chromium.org/12217121/diff/1/ash/system/date/date_view.cc
File ash/system/date/date_view.cc (right):

https://codereview.chromium.org/12217121/diff/1/ash/system/date/date_view.cc#...
ash/system/date/date_view.cc:143: now, base::k12HourClock, base:: kKeepAmPm));
On 2013/02/12 01:04:03, Jun Mukai wrote:
> Is there some reason to be comma-separated rather than
IDS_ASH_STATUS_TRAY_DATE?
> Sometimes people want to hear in their native language?
> # I don't know which is better actually, probably good to ask dmazzoni
IDS_ASH_STATUS_TRAY_DATE has the week in short format, like "Mon", "Fri", our
a11y system does not read it correctly. So I would like to use a longer format.
I add a "," in between date and time, so that the a11y will has a little pause.
Otherwise, it reads like "Friday, Feburary 11, 20014:00 pm".

[Jun Mukai, 2013-02-12 01:15:05]

lgtm

https://codereview.chromium.org/12217121/diff/1/ash/system/date/date_view.cc
File ash/system/date/date_view.cc (right):

https://codereview.chromium.org/12217121/diff/1/ash/system/date/date_view.cc#...
ash/system/date/date_view.cc:143: now, base::k12HourClock, base:: kKeepAmPm));
On 2013/02/12 01:07:38, jennyz wrote:
> On 2013/02/12 01:04:03, Jun Mukai wrote:
> > Is there some reason to be comma-separated rather than
> IDS_ASH_STATUS_TRAY_DATE?
> > Sometimes people want to hear in their native language?
> > # I don't know which is better actually, probably good to ask dmazzoni
> IDS_ASH_STATUS_TRAY_DATE has the week in short format, like "Mon", "Fri", our
> a11y system does not read it correctly. So I would like to use a longer
format.
> I add a "," in between date and time, so that the a11y will has a little
pause.
> Otherwise, it reads like "Friday, Feburary 11, 20014:00 pm".

ah, that makes sense. thanks!

[commit-bot: I haz the power, 2013-02-12 01:16:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jennyz@chromium.org/12217121/1

[commit-bot: I haz the power, 2013-02-12 05:06:57]

Change committed as 181862