Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12217109: Add didChangeVisibleSSLState() to WebContentsObserverAndroid. (Closed)

Created:
7 years, 10 months ago by Philippe
Modified:
7 years, 10 months ago
Reviewers:
bulach, Jay Civelli
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, ppi
Visibility:
Public.

Description

Add didChangeVisibleSSLState() to WebContentsObserverAndroid. This is needed on Android by the application side since r181488. BUG=175159 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182250

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M content/browser/android/web_contents_observer_android.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/android/web_contents_observer_android.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/WebContentsObserverAndroid.java View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Philippe
7 years, 10 months ago (2013-02-12 09:54:34 UTC) #1
bulach
lgtm, thanks!
7 years, 10 months ago (2013-02-12 13:44:56 UTC) #2
Philippe
On 2013/02/12 13:44:56, bulach wrote: > lgtm, thanks! Thanks Marcus!
7 years, 10 months ago (2013-02-12 13:49:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pliard@chromium.org/12217109/1
7 years, 10 months ago (2013-02-12 13:51:14 UTC) #4
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 10 months ago (2013-02-12 14:16:37 UTC) #5
Philippe
It would have been too easy if the initial CL adding didChangeVisibleSSLState() to WebContentsObserver hadn't ...
7 years, 10 months ago (2013-02-12 16:05:14 UTC) #6
Philippe
On 2013/02/12 16:05:14, Philippe wrote: > It would have been too easy if the initial ...
7 years, 10 months ago (2013-02-13 11:24:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pliard@chromium.org/12217109/1
7 years, 10 months ago (2013-02-13 15:40:42 UTC) #8
commit-bot: I haz the power
7 years, 10 months ago (2013-02-13 17:45:40 UTC) #9
Message was sent while issue was closed. 
Change committed as 182250

Powered by Google App Engine
This is Rietveld 408576698