Remove unused pieces of URLRequestJobFactory API.

Remove unused pieces of URLRequestJobFactory API.
This is mostly the Interceptor logic which is now unused.
Also switch DebugDevToolsInterceptor (the last remaining
Interceptor) to a ProtocolHandler.

BUG=146602, 161529
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182016

[pauljensen, 2013-02-09 04:14:54]

Erik, PTAL.  Removes 424 lines :)

[mkosiba (inactive), 2013-02-09 15:49:28]

LGTM for android_webview

[erikwright (departed), 2013-02-11 15:06:48]

LFATM. A major step forward!

LGTM.

[pauljensen, 2013-02-11 15:31:39]

Matt, could you PTAL?  Should be a much easier read than my other monsters :)

[mmenke, 2013-02-11 15:33:00]

Will do.  Have a couple other things to do this morning, but should get to
it this afternoon (Honest!).


On Mon, Feb 11, 2013 at 10:31 AM, <pauljensen@chromium.org> wrote:

> Matt, could you PTAL?  Should be a much easier read than my other monsters
> :)
>
>
https://codereview.chromium.**org/12217095/<https://codereview.chromium.org/1...
>

[mmenke, 2013-02-11 17:19:32]

LGTM, just nits mostly involving cleanup not directly related to this CL.

https://codereview.chromium.org/12217095/diff/8001/android_webview/browser/ne...
File android_webview/browser/net/aw_url_request_job_factory.h (right):

https://codereview.chromium.org/12217095/diff/8001/android_webview/browser/ne...
android_webview/browser/net/aw_url_request_job_factory.h:31: //
net::URLRequestJobFactory implementation
nit:  These typically end in a colon or period.

https://codereview.chromium.org/12217095/diff/8001/net/url_request/protocol_i...
File net/url_request/protocol_intercept_job_factory.cc (right):

https://codereview.chromium.org/12217095/diff/8001/net/url_request/protocol_i...
net/url_request/protocol_intercept_job_factory.cc:9: #include
"net/base/load_flags.h"
While you're here, looks like none of these 3 includes is needed.

Don't think url_request_job_manager.h is needed, either.

https://codereview.chromium.org/12217095/diff/8001/net/url_request/protocol_i...
net/url_request/protocol_intercept_job_factory.cc:12: class GURL;
This forward declaration is in the header.

https://codereview.chromium.org/12217095/diff/8001/net/url_request/url_request.h
File net/url_request/url_request.h (right):

https://codereview.chromium.org/12217095/diff/8001/net/url_request/url_reques...
net/url_request/url_request.h:36: class ComponentUpdateInterceptor;
Don't believe this is needed any more.

https://codereview.chromium.org/12217095/diff/8001/net/url_request/url_reques...
net/url_request/url_request.h:63: class AutoUpdateInterceptor;
We can remove this, too.  Think we can remove the UserScriptListenerTest as
well.

https://codereview.chromium.org/12217095/diff/8001/net/url_request/url_reques...
net/url_request/url_request.h:78: class CannedResponseInterceptor;
This doesn't seem to be used any more, either.

https://codereview.chromium.org/12217095/diff/8001/net/url_request/url_reques...
File net/url_request/url_request_job_factory_impl.h (right):

https://codereview.chromium.org/12217095/diff/8001/net/url_request/url_reques...
net/url_request/url_request_job_factory_impl.h:9: #include <vector>
While you're here, please add a blank line after the standard headers.

https://codereview.chromium.org/12217095/diff/8001/net/url_request/url_reques...
net/url_request/url_request_job_factory_impl.h:10: #include "base/basictypes.h"
Also while you're here, please add base/compiler_specific.h for OVERRIDE.

[pauljensen, 2013-02-12 14:03:03]

I addressed Matt's comments.
James, can you please review chrome/browser/custom_handlers/?  It's only
deletions.

[James Hawkins, 2013-02-12 18:39:01]

lgtm

[commit-bot: I haz the power, 2013-02-12 18:47:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pauljensen@chromium.org/12217095/12002

[commit-bot: I haz the power, 2013-02-12 21:22:50]

Change committed as 182016