Add policies to control Chrome OS power management

chrome/browser/policy/configuration_policy_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/policy/configuration_policy_handler.h"
 
 #include <string>
 
 #include "base/file_path.h"
 #include "base/json/json_writer.h"
@@ skipping 269 matching lines @@
         errors->AddError(policy_name(),
                          entry - list_value->begin(),
                          IDS_POLICY_OUT_OF_RANGE_ERROR);
       }
     }
   }
 
   return true;
 }
 
+// IntPercentageToDoublePolicyHandler implementation ---------------------------
+
+IntPercentageToDoublePolicyHandler::IntPercentageToDoublePolicyHandler(
+    const char* policy_name,
+    const char* pref_path)
+    : TypeCheckingPolicyHandler(policy_name, base::Value::TYPE_INTEGER),
+      pref_path_(pref_path) {}

[Mattias Nissler (ping if slow), 2013/02/07 16:52:01]

Should this also have a CheckPolicySettings that makes sure the integer is
within [0, 100]?

[bartfab (slow), 2013/02/07 17:25:53]

For the policy in question, the valid range actually is [100, ∞[. But there is
not really a need to check it as the backend will clamp values to the range. If
you feel strongly, I will add a check and will rename
|IntPercentageToDoublePolicyHandler| from its generic name to a name referencing
the specific policy it validates.

[Mattias Nissler (ping if slow), 2013/02/08 09:47:49]

It'd be nice to be able to get feedback in about:policy if the value is out of
range. Maybe you want to make a generic IntRangePolicyHandler base class that
does the error flagging and clamping? And then have a subclass that takes care
of the divide-by-100-convert-to-double business? Anyhow, that's a nice-to-have,
fine to land without these tweaks.

[bartfab (slow), 2013/02/08 11:39:24]

Done.

+
+void IntPercentageToDoublePolicyHandler::ApplyPolicySettings(
+    const PolicyMap& policies,
+    PrefValueMap* prefs) {
+  const base::Value* value = policies.GetValue(policy_name());
+  int percentage;
+  if (value && value->GetAsInteger(&percentage)) {
+    prefs->SetValue(pref_path_, base::Value::CreateDoubleValue(
+        static_cast<double>(percentage) / 100.));
+  }
+}
+
 // ExtensionListPolicyHandler implementation -----------------------------------
 
 ExtensionListPolicyHandler::ExtensionListPolicyHandler(const char* policy_name,
                                                        const char* pref_path,
                                                        bool allow_wildcards)
     : TypeCheckingPolicyHandler(policy_name, base::Value::TYPE_LIST),
       pref_path_(pref_path),
       allow_wildcards_(allow_wildcards) {}
 
 ExtensionListPolicyHandler::~ExtensionListPolicyHandler() {}
@@ skipping 1161 matching lines @@
           errors->AddError(policy_name(),
                            IDS_POLICY_OUT_OF_RANGE_ERROR,
                            base::IntToString(restore_value));
       }
     }
   }
   return true;
 }
 
 }  // namespace policy