Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 12217066: Make message listener API backwards compatible. (Closed)

Created:
7 years, 10 months ago by Yang
Modified:
7 years, 9 months ago
Reviewers:
ulan
CC:
v8-dev
Visibility:
Public.

Description

Make message listener API backwards compatible. R=ulan@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=13762

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -7 lines) Patch
M include/v8.h View 1 chunk +5 lines, -1 line 0 comments Download
M src/api.cc View 2 chunks +8 lines, -3 lines 0 comments Download
M src/messages.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M test/cctest/test-api.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Yang
7 years, 10 months ago (2013-02-07 13:55:29 UTC) #1
Yang
On 2013/02/07 13:55:29, Yang wrote: This fixes build breakages caused by https://chromiumcodereview.appspot.com/11014017 while keeping the ...
7 years, 10 months ago (2013-02-07 13:56:23 UTC) #2
ulan
LGTM
7 years, 10 months ago (2013-02-15 09:56:37 UTC) #3
Yang
7 years, 9 months ago (2013-02-27 14:35:45 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r13762 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698