History: Fix selecting multiple visits.

chrome/browser/resources/history/history.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 <include src="../uber/uber_utils.js">
 
 ///////////////////////////////////////////////////////////////////////////////
 // Globals:
 /** @const */ var RESULTS_PER_PAGE = 150;
 
@@ skipping 18 matching lines @@
 
 ///////////////////////////////////////////////////////////////////////////////
 // Visit:
 
 /**
  * Class to hold all the information about an entry in our model.
  * @param {Object} result An object containing the visit's data.
  * @param {boolean} continued Whether this visit is on the same day as the
  *     visit before it.
  * @param {HistoryModel} model The model object this entry belongs to.
- * @param {number} id The identifier for the entry.
  * @constructor
  */
-function Visit(result, continued, model, id) {
+function Visit(result, continued, model) {
   this.model_ = model;
   this.title_ = result.title;
   this.url_ = result.url;
   this.starred_ = result.starred;
   this.snippet_ = result.snippet || '';
-  this.id_ = id;
+  // The id will be set according to when the visit was displayed, not
+  // received. Set to -1 to show that it has not been set yet.
+  this.id_ = -1;
 
   this.isRendered = false;  // Has the visit already been rendered on the page?
 
   // Holds the timestamps of duplicates of this visit (visits to the same URL on
   // the same day).
   this.duplicateTimestamps_ = [];
 
   // All the date information is public so that owners can compare properties of
   // two items easily.
 
@@ skipping 37 matching lines @@
   var time = createElementWithClassName('div', 'time');
   var entryBox = createElementWithClassName('label', 'entry-box');
   var domain = createElementWithClassName('div', 'domain');
 
   var dropDown = createElementWithClassName('button', 'drop-down');
   dropDown.value = 'Open action menu';
   dropDown.title = loadTimeData.getString('actionMenuDescription');
   dropDown.setAttribute('menu', '#action-menu');
   cr.ui.decorate(dropDown, MenuButton);
 
+  this.id_ = this.model_.nextVisitId_++;
+
   // Checkbox is always created, but only visible on hover & when checked.
   var checkbox = document.createElement('input');
   checkbox.type = 'checkbox';
   checkbox.id = 'checkbox-' + this.id_;
   checkbox.time = this.date.getTime();
   checkbox.addEventListener('click', checkboxClicked);
   time.appendChild(checkbox);
 
   // Keep track of the drop down that triggered the menu, so we know
   // which element to apply the command to.
@@ skipping 313 matching lines @@
       this.urlsFromLastSeenDay_ = {};
 
     // Only create a new Visit object for the first visit to a URL on a
     // particular day.
     var visit = this.urlsFromLastSeenDay_[thisResult.url];
     if (visit) {
       // Record the timestamp of the duplicate visit.
       visit.addDuplicateTimestamp(thisResult.timestamp);
       continue;
     }
-    visit = new Visit(thisResult, isSameDay, this, this.nextVisitId_++);
+    visit = new Visit(thisResult, isSameDay, this);
     this.urlsFromLastSeenDay_[thisResult.url] = visit;
     this.visits_.push(visit);
     this.changed = true;
     lastDay = thisDay;
   }
 
   this.updateSearch_();
 };
 
 /**
@@ skipping 1097 matching lines @@
     historyView.reload();
 }
 
 // Add handlers to HTML elements.
 document.addEventListener('DOMContentLoaded', load);
 
 // This event lets us enable and disable menu items before the menu is shown.
 document.addEventListener('canExecute', function(e) {
   e.canExecute = true;
 });