Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2453)

Unified Diff: chrome/browser/extensions/extension_icon_image.cc

Issue 12213093: Remove ImageLoadingTracker class (Closed) Base URL: https://git.chromium.org/chromium/src.git@Issue_163929
Patch Set: Fix merge conflict Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_icon_image.cc
diff --git a/chrome/browser/extensions/extension_icon_image.cc b/chrome/browser/extensions/extension_icon_image.cc
index e4e1fb0b10c7459925b07d1b0743ac737a76c8be..c2fd3cd6cd42ee993cc1fbd5207a13463e5ffe0e 100644
--- a/chrome/browser/extensions/extension_icon_image.cc
+++ b/chrome/browser/extensions/extension_icon_image.cc
@@ -27,22 +27,15 @@
// the image representation, the default icon's representation for the
// requested scale factor is returned by ImageSkiaSource.
// - If the extension has the resource, IconImage tries to load it using
-// ImageLoadingTracker.
-// - |ImageLoadingTracker| may return both synchronously and asynchronously.
-// 1. |ImageLoadingTracker| is synchronous.
-// - If image representation resource is successfully loaded, the
-// representation returned by ImageSkiaSource is created from the loaded
-// bitmap.
-// - If resource loading fails, ImageSkiaSource returns default icon's
-// representation.
-// 2. |ImageLoadingTracker| is asynchronous.
+// ImageLoader.
+// - |ImageLoader| is asynchronous.
// - ImageSkiaSource will initially return transparent image resource of the
// desired size.
// - The image will be updated with an appropriate image representation when
-// the |ImageLoadingTracker| finishes. The image representation is chosen
-// the same way as in the synchronous case. The observer is notified of the
-// image change, unless the added image representation is transparent (in
-// which case the image had already contained the appropriate image
+// the |ImageLoader| finishes. The image representation is chosen the same
+// way as in the synchronous case. The observer is notified of the image
+// change, unless the added image representation is transparent (in which
+// case the image had already contained the appropriate image
// representation).
namespace {
« no previous file with comments | « chrome/browser/extensions/api/webview/webview_api.cc ('k') | chrome/browser/extensions/extension_icon_manager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698