Remove ImageLoadingTracker class

Remove ImageLoadingTracker class, as it is not used anymore.

* Remove related methods in Extension: Set/GetCachedImage
* Remove related unit tests
* Update all comments mentioning ImageLoadingTracker to mention ImageLoader instead

BUG=163929
TBR=sky@chromium.org (for mechanical changes in chrome/.)

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182039

[rpaquay, 2013-02-08 20:46:39]

This is a pretty mechanical change to remove all remaining references to
ImageLoadingTracker. I recently made a few changes to replace all usages with
ImageLoader instead.

Reviewers,

please take a look at the following files:

derat@
  chrome/browser/ui/ash/

asargent@
  chrome/browser/extensions/
  chrome/chrome_browser_extensions.gypi
  chrome/chrome_tests_unit.gypi
  chrome/browser/extensions/

rohitrao@
  chrome/browser/ui/cocoa/

oshima@
  ui/gfx/images/

[rohitrao (ping after 24h), 2013-02-08 20:51:59]

Cocoa changes LGTM

[asargent_no_longer_on_chrome, 2013-02-08 21:17:33]

LGTM

[Daniel Erat, 2013-02-08 22:23:25]

LGTM (feel free to TBR changes with non-controversial corrections to comments)

[oshima, 2013-02-08 22:30:02]

image_skia* lgtm (TBR is fine with me too for this type of change)

[commit-bot: I haz the power, 2013-02-08 22:34:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rpaquay@chromium.org/12213093/1

[commit-bot: I haz the power, 2013-02-08 23:02:18]

Sorry for I got bad news for ya.
Compile failed with a clobber build on linux_aura.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-02-11 22:42:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rpaquay@chromium.org/12213093/1024

[commit-bot: I haz the power, 2013-02-11 23:17:32]

Sorry for I got bad news for ya.
Compile failed with a clobber build on android_clang_dbg.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_cl...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-02-12 01:09:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rpaquay@chromium.org/12213093/5008

[commit-bot: I haz the power, 2013-02-12 05:06:50]

Failed to apply patch for chrome/common/extensions/extension.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/common/extensions/extension.cc
  Hunk #1 succeeded at 189 (offset 1 line).
  Hunk #2 succeeded at 866 (offset 1 line).
  Hunk #3 FAILED at 2526.
  1 out of 3 hunks FAILED -- saving rejects to file
chrome/common/extensions/extension.cc.rej

Patch:       chrome/common/extensions/extension.cc
Index: chrome/common/extensions/extension.cc
diff --git a/chrome/common/extensions/extension.cc
b/chrome/common/extensions/extension.cc
index
f1127f0b6cdedd02494822582f1254ff610a39d3..d3fd6d58ee413023f88c46120fb7727404d9eab9
100644
--- a/chrome/common/extensions/extension.cc
+++ b/chrome/common/extensions/extension.cc
@@ -188,11 +188,6 @@ bool ReadLaunchDimension(const extensions::Manifest*
manifest,
   return true;
 }
 
-std::string SizeToString(const gfx::Size& max_size) {
-  return base::IntToString(max_size.width()) + "x" +
-         base::IntToString(max_size.height());
-}
-
 bool ContainsManifestForbiddenPermission(const APIPermissionSet& apis,
                                          string16* error) {
   CHECK(error);
@@ -870,34 +865,6 @@ GURL Extension::GetFullLaunchURL() const {
                                        url().Resolve(launch_local_path());
 }
 
-void Extension::SetCachedImage(const ExtensionResource& source,
-                               const SkBitmap& image,
-                               const gfx::Size& original_size) const {
-  DCHECK(source.extension_root() == path());  // The resource must come from
-                                              // this extension.
-  const base::FilePath& path = source.relative_path();
-  gfx::Size actual_size(image.width(), image.height());
-  std::string location;
-  if (actual_size != original_size)
-    location = SizeToString(actual_size);
-  image_cache_[ImageCacheKey(path, location)] = image;
-}
-
-bool Extension::HasCachedImage(const ExtensionResource& source,
-                               const gfx::Size& max_size) const {
-  DCHECK(source.extension_root() == path());  // The resource must come from
-                                              // this extension.
-  return GetCachedImageImpl(source, max_size) != NULL;
-}
-
-SkBitmap Extension::GetCachedImage(const ExtensionResource& source,
-                                   const gfx::Size& max_size) const {
-  DCHECK(source.extension_root() == path());  // The resource must come from
-                                              // this extension.
-  SkBitmap* image = GetCachedImageImpl(source, max_size);
-  return image ? *image : SkBitmap();
-}
-
 bool Extension::CanExecuteScriptOnPage(const GURL& document_url,
                                        const GURL& top_frame_url,
                                        int tab_id,
@@ -2559,29 +2526,6 @@ bool Extension::LoadThemeDisplayProperties(const
DictionaryValue* theme_value,
   }
   return true;
 }
-SkBitmap* Extension::GetCachedImageImpl(const ExtensionResource& source,
-                                        const gfx::Size& max_size) const {
-  const base::FilePath& path = source.relative_path();
-
-  // Look for exact size match.
-  ImageCache::iterator i = image_cache_.find(
-      ImageCacheKey(path, SizeToString(max_size)));
-  if (i != image_cache_.end())
-    return &(i->second);
-
-  // If we have the original size version cached, return that if it's small
-  // enough.
-  i = image_cache_.find(ImageCacheKey(path, std::string()));
-  if (i != image_cache_.end()) {
-    const SkBitmap& image = i->second;
-    if (image.width() <= max_size.width() &&
-        image.height() <= max_size.height()) {
-      return &(i->second);
-    }
-  }
-
-  return NULL;
-}
 
 // Helper method that loads a UserScript object from a dictionary in the
 // content_script list of the manifest.

[commit-bot: I haz the power, 2013-02-12 19:22:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rpaquay@chromium.org/12213093/12017

[commit-bot: I haz the power, 2013-02-12 22:14:27]

Change committed as 182039