Issue 12213062: Invalid flags now result in a GOAWAY

Issue 12213062: Invalid flags now result in a GOAWAY (Closed)

Created:
7 years, 10 months ago by akalin

Modified:
7 years, 10 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Invalid flags now result in a GOAWAY This lands server change 40997047. Also add TODOs to upstream OnControlFrameCompressed and to fix use of GMock objects. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181910

Patch Set 1 : Upload correct patch #

Total comments: 4

Patch Set 2 : Fix indentation #

Patch Set 3 : Fix test expectations #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+398 lines, -41 lines)			Patch
M	net/spdy/spdy_framer.h	View	1 2	2 chunks	+11 lines, -8 lines	0 comments	Download
M	net/spdy/spdy_framer.cc	View	1	5 chunks	+51 lines, -17 lines	0 comments	Download
M	net/spdy/spdy_framer_test.cc	View	1 2	4 chunks	+335 lines, -16 lines	0 comments	Download
M	net/spdy/spdy_session.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Ryan Hamilton

lgtm https://codereview.chromium.org/12213062/diff/2003/net/spdy/spdy_framer.cc File net/spdy/spdy_framer.cc (right): https://codereview.chromium.org/12213062/diff/2003/net/spdy/spdy_framer.cc#newcode427 net/spdy/spdy_framer.cc:427: } fix indentation https://codereview.chromium.org/12213062/diff/2003/net/spdy/spdy_framer.h File net/spdy/spdy_framer.h (right): https://codereview.chromium.org/12213062/diff/2003/net/spdy/spdy_framer.h#newcode274 ...

7 years, 10 months ago (2013-02-07 17:07:45 UTC) #2

akalin

Also added a couple of TODOs. Committing. https://codereview.chromium.org/12213062/diff/2003/net/spdy/spdy_framer.cc File net/spdy/spdy_framer.cc (right): https://codereview.chromium.org/12213062/diff/2003/net/spdy/spdy_framer.cc#newcode427 net/spdy/spdy_framer.cc:427: } On ...

7 years, 10 months ago (2013-02-12 06:50:12 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/akalin@chromium.org/12213062/2005

7 years, 10 months ago (2013-02-12 06:51:36 UTC) #4

Message was sent while issue was closed.

Change committed as 181910

Expand Messages | Collapse Messages