Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 12213027: Ignore C4267 size_t to int truncations in win64 media_unittests (Closed)

Created:
7 years, 10 months ago by wolenetz
Modified:
7 years, 10 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Ignore C4267 size_t to int truncations in win64 media_unittests BUG=173697, 166496 TEST=media_unittests target builds without C4267 errors. With other build errors fixed in privates (fix win64 gmock_mutant template functor redefinitions & lift MEDIA...INTRINSICS... definition into yuv_convert.h and use it to not link in methods that use MMX intrinsics), media_unittests executes Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180874

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M media/media.gyp View 2 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
wolenetz
Please review. Thanks, Matt
7 years, 10 months ago (2013-02-05 22:46:43 UTC) #1
DaleCurtis
Are there too many of these to fix right away?
7 years, 10 months ago (2013-02-05 22:51:31 UTC) #2
wolenetz
On 2013/02/05 22:51:31, DaleCurtis wrote: > Are there too many of these to fix right ...
7 years, 10 months ago (2013-02-05 23:19:25 UTC) #3
DaleCurtis
Since you've already got one suppression in, this lgtm, but 27 seems small enough to ...
7 years, 10 months ago (2013-02-05 23:33:28 UTC) #4
wolenetz
On 2013/02/05 23:33:28, DaleCurtis wrote: > Since you've already got one suppression in, this lgtm, ...
7 years, 10 months ago (2013-02-05 23:53:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wolenetz@chromium.org/12213027/1
7 years, 10 months ago (2013-02-05 23:55:11 UTC) #6
commit-bot: I haz the power
7 years, 10 months ago (2013-02-06 02:46:09 UTC) #7
Message was sent while issue was closed.
Change committed as 180874

Powered by Google App Engine
This is Rietveld 408576698