Issue 12213021: Android content_browsertests: Allow processing java tasks in nested mode.

Issue 12213021: Android content_browsertests: Allow processing java tasks in nested mode. (Closed)

Created:
7 years, 10 months ago by nilesh

Modified:
7 years, 10 months ago

Reviewers:
Jay Civelli, jochen (gone - plz use gerrit)

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Android content_browsertests: Allow processing java tasks in nested mode. Adding support for processing java side tasks while in nested mode. We process messages from the java messagequeue using reflection, till the queue is idle. TBR=jochen@chromium.org TBRing for content_shell.gypi BUG=138275 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181823

Patch Set 1 #

Patch Set 2 : #

Total comments: 10

Patch Set 3 : Addressed comments. #

Patch Set 4 : Rebase #

Patch Set 5 : Rebase #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+199 lines, -9 lines)			Patch
M	content/content_shell.gypi	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/public/android/java/src/org/chromium/content/browser/AndroidBrowserProcess.java	View		1 chunk	+5 lines, -1 line	0 comments	Download
M	content/shell/android/browsertests_apk/content_browser_tests_android.cc	View	1 2 3 4	4 chunks	+11 lines, -1 line	0 comments	Download
A	content/shell/android/browsertests_apk/src/org/chromium/content_browsertests_apk/BrowserTestSystemMessageHandler.java	View	1 2	1 chunk	+128 lines, -0 lines	0 comments	Download
M	content/shell/android/browsertests_apk/src/org/chromium/content_browsertests_apk/ContentBrowserTestsActivity.java	View		3 chunks	+4 lines, -1 line	0 comments	Download
M	content/test/browser_test_message_pump_android.h	View		3 chunks	+4 lines, -3 lines	0 comments	Download
M	content/test/browser_test_message_pump_android.cc	View	1 2	5 chunks	+46 lines, -3 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Jay Civelli

https://codereview.chromium.org/12213021/diff/2001/content/shell/android/browsertests_apk/src/org/chromium/content_browsertests_apk/BrowserTestSystemMessageHandler.java File content/shell/android/browsertests_apk/src/org/chromium/content_browsertests_apk/BrowserTestSystemMessageHandler.java (right): https://codereview.chromium.org/12213021/diff/2001/content/shell/android/browsertests_apk/src/org/chromium/content_browsertests_apk/BrowserTestSystemMessageHandler.java#newcode37 content/shell/android/browsertests_apk/src/org/chromium/content_browsertests_apk/BrowserTestSystemMessageHandler.java:37: * Processes messages from the current MessageQuere till the ...

7 years, 10 months ago (2013-02-06 17:32:29 UTC) #2

nilesh

7 years, 10 months ago (2013-02-06 17:58:26 UTC) #3

https://codereview.chromium.org/12213021/diff/2001/content/shell/android/brow...
File
content/shell/android/browsertests_apk/src/org/chromium/content_browsertests_apk/BrowserTestSystemMessageHandler.java
(right):

https://codereview.chromium.org/12213021/diff/2001/content/shell/android/brow...
content/shell/android/browsertests_apk/src/org/chromium/content_browsertests_apk/BrowserTestSystemMessageHandler.java:37:
* Processes messages from the current MessageQuere till the queue becomes idle.
On 2013/02/06 17:32:29, Jay Civelli wrote:
> Typo: MessageQuere - > MessageQueue

Done.

https://codereview.chromium.org/12213021/diff/2001/content/shell/android/brow...
content/shell/android/browsertests_apk/src/org/chromium/content_browsertests_apk/BrowserTestSystemMessageHandler.java:41:
private void runNestedLoopTillIdle() {
On 2013/02/06 17:32:29, Jay Civelli wrote:
> Should this return a bool in case it fails?

Done.

https://codereview.chromium.org/12213021/diff/2001/content/shell/android/brow...
content/shell/android/browsertests_apk/src/org/chromium/content_browsertests_apk/BrowserTestSystemMessageHandler.java:56:
nextMethod = messageQueueClazz.getDeclaredMethod("next", new Class[]{});
On 2013/02/06 17:32:29, Jay Civelli wrote:
> I think you can pass null instead of new Class[]{}.

Done.

https://codereview.chromium.org/12213021/diff/2001/content/shell/android/brow...
content/shell/android/browsertests_apk/src/org/chromium/content_browsertests_apk/BrowserTestSystemMessageHandler.java:64:
while(!quitLoop) {
On 2013/02/06 17:32:29, Jay Civelli wrote:
> Nit: add space after while.

Done.

https://codereview.chromium.org/12213021/diff/2001/content/shell/android/brow...
content/shell/android/browsertests_apk/src/org/chromium/content_browsertests_apk/BrowserTestSystemMessageHandler.java:67:
msg = (Message)nextMethod.invoke(queue, new Object[]{});
On 2013/02/06 17:32:29, Jay Civelli wrote:
> You can pass null instead of new Object[].

Done.

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nileshagrawal@chromium.org/12213021/15001

7 years, 10 months ago (2013-02-11 21:43:11 UTC) #6

Message was sent while issue was closed.

Change committed as 181823

Expand Messages | Collapse Messages