Issue 12212155: When focusing a tab via the extension API, bring focus to its containing window

Issue 12212155: When focusing a tab via the extension API, bring focus to its containing window (Closed)

Created:
7 years, 10 months ago by Matt Perry

Modified:
7 years, 10 months ago

Reviewers:
not at google - send to devlin

CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

When focusing a tab via the extension API, bring focus to its containing window as well. BUG=170936 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182130

Patch Set 3 : #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -2 lines)			Patch
	M	chrome/app/generated_resources.grd	View		1 chunk	+3 lines, -0 lines	0 comments	Download
	M	chrome/browser/ui/views/extensions/extension_installed_bubble.cc	View	1 2	1 chunk	+6 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

not at google - send to devlin

lgtm https://codereview.chromium.org/12212155/diff/1/chrome/browser/extensions/api/tabs/tabs_api.cc File chrome/browser/extensions/api/tabs/tabs_api.cc (right): https://codereview.chromium.org/12212155/diff/1/chrome/browser/extensions/api/tabs/tabs_api.cc#newcode1121 chrome/browser/extensions/api/tabs/tabs_api.cc:1121: params.target_contents); here and below if you activate it ...

7 years, 10 months ago (2013-02-13 01:28:11 UTC) #2

Matt Perry

https://codereview.chromium.org/12212155/diff/1/chrome/browser/extensions/api/tabs/tabs_api.cc File chrome/browser/extensions/api/tabs/tabs_api.cc (right): https://codereview.chromium.org/12212155/diff/1/chrome/browser/extensions/api/tabs/tabs_api.cc#newcode1121 chrome/browser/extensions/api/tabs/tabs_api.cc:1121: params.target_contents); On 2013/02/13 01:28:11, kalman wrote: > here and ...

7 years, 10 months ago (2013-02-13 01:38:52 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpcomplete@chromium.org/12212155/5001

7 years, 10 months ago (2013-02-13 01:40:50 UTC) #4

Message was sent while issue was closed.

Change committed as 182130

Expand Messages | Collapse Messages