Issue 12212136: Ensures Widget::InitParams::top_level is set correctly before calling

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12212136: Ensures Widget::InitParams::top_level is set correctly before calling (Closed)

Created:
7 years, 10 months ago by sky

Modified:
7 years, 10 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, tfarina, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Ensures Widget::InitParams::top_level is set correctly before calling through the ViewsDelegate::OnBeforeWidgetInit(). This way if the delegate needs top_level (as we do for win-aura) its set correctly. BUG=175115 TEST=covered by unit test now. R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181983

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+48 lines, -4 lines)			Patch
M	ui/views/test/test_views_delegate.h	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	ui/views/widget/widget.cc	View	1 chunk	+5 lines, -2 lines	0 comments	Download
M	ui/views/widget/widget_unittest.cc	View	1 chunk	+40 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/12212136/1

7 years, 10 months ago (2013-02-12 17:42:07 UTC) #3

Message was sent while issue was closed.

Change committed as 181983