Issue 12212133: Remove unnecessary condition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12212133: Remove unnecessary condition. (Closed)

Created:
7 years, 10 months ago by Seigo Nonaka

Modified:
7 years, 10 months ago

Reviewers:
satorux1

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove unnecessary condition. ShutdownAndBlock function can be called multiple times safely. So checking |shutdown_completed_| in OnDisonnected function is not necessary. BUG=174431 TEST=Checked no crash at sing out. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182161

Patch Set 1 #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -5 lines)			Patch
	M	dbus/bus.cc	View		1 chunk	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/12212133/1

7 years, 10 months ago (2013-02-13 01:22:47 UTC) #3

Message was sent while issue was closed.

Change committed as 182161

Expand Messages | Collapse Messages