Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Issue 12212099: cc: remove FontAtlas (Closed)

Created:
7 years, 10 months ago by egraether
Modified:
7 years, 10 months ago
Reviewers:
danakj, jamesr, piman
CC:
chromium-reviews, jonathan.backer, Ian Vollick, jam, apatrick_chromium, joi+watch-content_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, cc-bugs_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

cc: remove FontAtlas After switching the HudLayer to use skia's font rendering the FontAtlas has become obsolete. This change removes the FontAtlas and all the related plumbing. BUG=172284 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182150

Patch Set 1 #

Patch Set 2 : Rebase to 182043 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -358 lines) Patch
M cc/cc.gyp View 1 1 chunk +0 lines, -2 lines 0 comments Download
D cc/font_atlas.h View 1 chunk +0 lines, -73 lines 0 comments Download
D cc/font_atlas.cc View 1 chunk +0 lines, -151 lines 0 comments Download
M cc/heads_up_display_layer.h View 2 chunks +0 lines, -9 lines 0 comments Download
M cc/heads_up_display_layer.cc View 2 chunks +0 lines, -18 lines 0 comments Download
M cc/heads_up_display_layer_impl.h View 4 chunks +0 lines, -6 lines 0 comments Download
M cc/heads_up_display_layer_impl.cc View 2 chunks +0 lines, -17 lines 0 comments Download
M cc/layer_tree_debug_state.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M cc/layer_tree_debug_state.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M cc/layer_tree_host.cc View 1 2 chunks +0 lines, -4 lines 0 comments Download
M cc/layer_tree_host_client.h View 2 chunks +0 lines, -4 lines 0 comments Download
M cc/test/fake_layer_tree_host_client.h View 2 chunks +0 lines, -3 lines 0 comments Download
M cc/test/fake_layer_tree_host_client.cc View 1 1 chunk +0 lines, -5 lines 0 comments Download
M cc/test/layer_tree_test_common.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M content/browser/renderer_host/compositor_impl_android.h View 2 chunks +0 lines, -2 lines 0 comments Download
M content/browser/renderer_host/compositor_impl_android.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M content/renderer/gpu/render_widget_compositor.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 1 2 chunks +0 lines, -15 lines 0 comments Download
M ui/compositor/compositor.h View 2 chunks +0 lines, -2 lines 0 comments Download
M ui/compositor/compositor.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M webkit/compositor_bindings/web_layer_tree_view_impl.h View 2 chunks +0 lines, -2 lines 0 comments Download
M webkit/compositor_bindings/web_layer_tree_view_impl.cc View 1 2 chunks +0 lines, -16 lines 0 comments Download
M webkit/compositor_bindings/web_layer_tree_view_impl_for_testing.h View 1 2 chunks +0 lines, -2 lines 0 comments Download
M webkit/compositor_bindings/web_layer_tree_view_impl_for_testing.cc View 1 2 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
egraether
This removes all occurrences of FontAtlas in the code base.
7 years, 10 months ago (2013-02-11 17:21:14 UTC) #1
jamesr
lgtm Woohoo! You'll need piman@'s stamp for the ui/compositor/ changes
7 years, 10 months ago (2013-02-11 17:26:14 UTC) #2
danakj
On Mon, Feb 11, 2013 at 9:26 AM, <jamesr@chromium.org> wrote: > lgtm > > Woohoo! ...
7 years, 10 months ago (2013-02-11 17:27:34 UTC) #3
egraether
@piman, can you approve the ui/compositor changes please?
7 years, 10 months ago (2013-02-11 17:57:52 UTC) #4
piman
lgtm
7 years, 10 months ago (2013-02-12 22:37:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/egraether@chromium.org/12212099/25
7 years, 10 months ago (2013-02-12 22:55:24 UTC) #6
commit-bot: I haz the power
7 years, 10 months ago (2013-02-13 06:55:17 UTC) #7
Message was sent while issue was closed.
Change committed as 182150

Powered by Google App Engine
This is Rietveld 408576698