Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 12212080: MIPS: Generate the TransitionElementsStub using Crankshaft (Closed)

Created:
7 years, 10 months ago by palfia
Modified:
7 years, 10 months ago
Reviewers:
kisg, Paul Lind, danno
CC:
v8-dev
Visibility:
Public.

Description

MIPS: Generate the TransitionElementsStub using Crankshaft Port r13585 (4174b9d2) Original commit message: This includes: * Adding support for saving callee-clobbered double registers in Crankshaft code. * Adding a new "HTrapAllocationMemento" hydrogen instruction to handle AllocationSiteInfo data in crankshafted stubs. * Adding a new "HAllocate" hydrogen instruction that can allocate raw memory from the GC in crankshafted code. * Support for manipulation of the hole in HChange instructions for Crankshafted stubs. * Utility routines to manually build loops and if statements containing hydrogen code. BUG= TEST= Committed: https://code.google.com/p/v8/source/detail?r=13655

Patch Set 1 #

Total comments: 2

Patch Set 2 : Removed unused flag #

Unified diffs Side-by-side diffs Delta from patch set Stats (+369 lines, -71 lines) Patch
M src/mips/assembler-mips.h View 3 chunks +3 lines, -3 lines 0 comments Download
M src/mips/assembler-mips-inl.h View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/code-stubs-mips.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M src/mips/codegen-mips.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/mips/deoptimizer-mips.cc View 4 chunks +22 lines, -7 lines 0 comments Download
M src/mips/lithium-codegen-mips.h View 1 2 chunks +3 lines, -1 line 0 comments Download
M src/mips/lithium-codegen-mips.cc View 13 chunks +250 lines, -47 lines 0 comments Download
M src/mips/lithium-mips.h View 8 chunks +40 lines, -3 lines 0 comments Download
M src/mips/lithium-mips.cc View 3 chunks +27 lines, -2 lines 0 comments Download
M src/mips/macro-assembler-mips.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 4 chunks +7 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
palfia
7 years, 10 months ago (2013-02-08 01:42:04 UTC) #1
danno
https://chromiumcodereview.appspot.com/12212080/diff/1/src/mips/lithium-codegen-mips.h File src/mips/lithium-codegen-mips.h (right): https://chromiumcodereview.appspot.com/12212080/diff/1/src/mips/lithium-codegen-mips.h#newcode62 src/mips/lithium-codegen-mips.h:62: support_aligned_spilled_doubles_(false), Do you need this boolean flag anywhere? It ...
7 years, 10 months ago (2013-02-11 15:26:41 UTC) #2
palfia
Added a new patchset, which removes the unused flag. https://codereview.chromium.org/12212080/diff/1/src/mips/lithium-codegen-mips.h File src/mips/lithium-codegen-mips.h (right): https://codereview.chromium.org/12212080/diff/1/src/mips/lithium-codegen-mips.h#newcode62 src/mips/lithium-codegen-mips.h:62: ...
7 years, 10 months ago (2013-02-11 19:18:23 UTC) #3
danno
lgtm It would be great if you did remove it on ARM, too, in a ...
7 years, 10 months ago (2013-02-13 12:23:53 UTC) #4
palfia
7 years, 10 months ago (2013-02-13 15:31:21 UTC) #5
Message was sent while issue was closed.
On 2013/02/13 12:23:53, danno wrote:
> lgtm
> 
> It would be great if you did remove it on ARM, too, in a separate CL. :-)

Submitted the new CL for ARM :-)

https://codereview.chromium.org/12258013/

Powered by Google App Engine
This is Rietveld 408576698