Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 12212076: Move web store data fetching and parsing out of WebstoreStandaloneInstaller. (Closed)

Created:
7 years, 10 months ago by xiyuan
Modified:
7 years, 10 months ago
CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org, zel, sergeygs, sky
Visibility:
Public.

Description

Move web store data fetching and parsing out of WebstoreStandaloneInstaller. So that the code could be shared with kiosk apps code. BUG=173749 TEST=Existing WebstoreStandaloneInstaller test should pass. R=asargent@chromium.org TBR=sky@chromium.org for chrome/chrome_browser_extensions.gypi Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182081

Patch Set 1 #

Total comments: 2

Patch Set 2 : for nit in #1 #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+299 lines, -144 lines) Patch
A chrome/browser/extensions/webstore_data_fetcher.h View 1 chunk +63 lines, -0 lines 0 comments Download
A chrome/browser/extensions/webstore_data_fetcher.cc View 1 1 chunk +176 lines, -0 lines 0 comments Download
A chrome/browser/extensions/webstore_data_fetcher_delegate.h View 1 chunk +35 lines, -0 lines 0 comments Download
M chrome/browser/extensions/webstore_standalone_installer.h View 6 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/extensions/webstore_standalone_installer.cc View 4 chunks +12 lines, -134 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 2 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
xiyuan
7 years, 10 months ago (2013-02-07 19:15:23 UTC) #1
asargent_no_longer_on_chrome
LGTM (+cc sergeygs as FYI since he's doing some work in this file currently as ...
7 years, 10 months ago (2013-02-12 18:40:10 UTC) #2
xiyuan
+sky for TBRing chrome/chrome_browser_extensions.gypi change. https://codereview.chromium.org/12212076/diff/1/chrome/browser/extensions/webstore_data_fetcher.cc File chrome/browser/extensions/webstore_data_fetcher.cc (right): https://codereview.chromium.org/12212076/diff/1/chrome/browser/extensions/webstore_data_fetcher.cc#newcode31 chrome/browser/extensions/webstore_data_fetcher.cc:31: // WebstoreDataFetcher::SafeWebstoreResponseParser On 2013/02/12 ...
7 years, 10 months ago (2013-02-12 18:49:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xiyuan@chromium.org/12212076/5001
7 years, 10 months ago (2013-02-12 18:59:05 UTC) #4
commit-bot: I haz the power
Failed to apply patch for chrome/chrome_browser_extensions.gypi: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 10 months ago (2013-02-12 18:59:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xiyuan@chromium.org/12212076/11
7 years, 10 months ago (2013-02-12 21:20:00 UTC) #6
commit-bot: I haz the power
7 years, 10 months ago (2013-02-13 01:22:01 UTC) #7
Message was sent while issue was closed.
Change committed as 182081

Powered by Google App Engine
This is Rietveld 408576698