[Autofill] Add ability to load Risk fingerprint data in AutofillDialogControllerImpl.

chrome/browser/ui/autofill/autofill_dialog_controller_impl.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_AUTOFILL_AUTOFILL_DIALOG_CONTROLLER_IMPL_H_
 #define CHROME_BROWSER_UI_AUTOFILL_AUTOFILL_DIALOG_CONTROLLER_IMPL_H_
 
 #include <vector>
 
 #include "base/callback.h"
 #include "base/memory/scoped_ptr.h"
+#include "base/memory/weak_ptr.h"
 #include "base/string16.h"
 #include "chrome/browser/autofill/field_types.h"
 #include "chrome/browser/autofill/form_structure.h"
 #include "chrome/browser/autofill/personal_data_manager.h"
 #include "chrome/browser/autofill/wallet/required_action.h"
 #include "chrome/browser/autofill/wallet/wallet_client.h"
 #include "chrome/browser/autofill/wallet/wallet_client_observer.h"
 #include "chrome/browser/ui/autofill/autofill_dialog_controller.h"
 #include "chrome/browser/ui/autofill/autofill_dialog_models.h"
 #include "chrome/browser/ui/autofill/autofill_dialog_types.h"
@@ skipping 10 matching lines @@
 class Profile;
 
 namespace content {
 class WebContents;
 }
 
 namespace autofill {
 
 class AutofillDialogView;
 
+namespace risk {
+class Fingerprint;
+}
+
 // This class drives the dialog that appears when a site uses the imperative
 // autocomplete API to fill out a form.
 class AutofillDialogControllerImpl : public AutofillDialogController,
                                      public AutofillPopupDelegate,
                                      public content::NotificationObserver,
                                      public SuggestionsMenuModelDelegate,
                                      public wallet::WalletClientObserver {
  public:
   AutofillDialogControllerImpl(
       content::WebContents* contents,
@@ skipping 145 matching lines @@
 
   // Returns the PersonalDataManager for |profile_|.
   PersonalDataManager* GetManager();
 
   // Like RequestedFieldsForSection, but returns a pointer.
   DetailInputs* MutableRequestedFieldsForSection(DialogSection section);
 
   // Hides |popup_controller_|'s popup view, if it exists.
   void HidePopup();
 
+  // Asynchronously loads fingerprint data to be sent to the Risk server, and
+  // calls OnDidLoadRiskFingerprintData() with the data once it's loaded.

[Evan Stade, 2013/02/07 01:34:53]

this function does not actually call OnDidLoadRiskFingerprintData, so this
comment seems misleading to me. Perhaps:

Asks risk module to asynchronously load fingerprint data. Data will be returned
via OnDidLoadRiskFingerprintData.

and then you can remove the 2 lines between the 2 functions.

[Ilya Sherman, 2013/02/07 01:58:29]

Done.

+  void LoadRiskFingerprintData();
+
+  // Callback from LoadRiskFingerprintData().
+  void OnDidLoadRiskFingerprintData(scoped_ptr<risk::Fingerprint> fingerprint);
+
   // The |profile| for |contents_|.
   Profile* const profile_;
 
   // The WebContents where the Autofill action originated.
   content::WebContents* const contents_;
 
   FormStructure form_structure_;
 
   // Whether the URL visible to the user when this dialog was requested to be
   // invoked is the same as |source_url_|.
@@ skipping 43 matching lines @@
 
   // The section for which |popup_controller_| is currently showing a popup
   // (if any).
   DialogSection section_showing_popup_;
 
   scoped_ptr<AutofillDialogView> view_;
 
   // A NotificationRegistrar for tracking the completion of sign-in.
   content::NotificationRegistrar registrar_;
 
+  base::WeakPtrFactory<AutofillDialogControllerImpl> weak_ptr_factory_;
+
   DISALLOW_COPY_AND_ASSIGN(AutofillDialogControllerImpl);
 };
 
 }  // namespace autofill
 
 #endif  // CHROME_BROWSER_UI_AUTOFILL_AUTOFILL_DIALOG_CONTROLLER_IMPL_H_