Issue 12212053: Moves calling TaskbarList::SetOverlayIcon to a separate thread. It

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12212053: Moves calling TaskbarList::SetOverlayIcon to a separate thread. It (Closed)

Created:
7 years, 10 months ago by sky

Modified:
7 years, 10 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, tfarina, jennb, jianli, Dmitry Titov, dcheng

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Moves calling TaskbarList::SetOverlayIcon to a separate thread. It turns out calling SetOverlayIcon() runs a nested message loop, which can result in all sorts of problems (and crashes). Since we don't care about the result I'm moving the call to a worker thread. BUG=174768 TEST=none R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182145

Patch Set 1 #

Patch Set 2 : Merge to trunk #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+130 lines, -75 lines)			Patch
M	chrome/browser/ui/views/avatar_menu_button.h	View		2 chunks	+1 line, -7 lines	0 comments	Download
M	chrome/browser/ui/views/avatar_menu_button.cc	View		1 chunk	+0 lines, -63 lines	0 comments	Download
M	chrome/browser/ui/views/frame/browser_non_client_frame_view.cc	View		2 chunks	+3 lines, -2 lines	0 comments	Download
A	chrome/browser/ui/views/frame/taskbar_decorator.h	View		1 chunk	+23 lines, -0 lines	0 comments	Download
A +	chrome/browser/ui/views/frame/taskbar_decorator.cc	View		1 chunk	+2 lines, -3 lines	0 comments	Download
A	chrome/browser/ui/views/frame/taskbar_decorator_win.cc	View		1 chunk	+97 lines, -0 lines	0 comments	Download
M	chrome/chrome_browser_ui.gypi	View	1	2 chunks	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/12212053/2001

7 years, 10 months ago (2013-02-12 22:14:36 UTC) #3

Message was sent while issue was closed.

Change committed as 182145

Expand Messages | Collapse Messages