Issue 12212038: Do not pass NULL to GetAsString().

Issue 12212038: Do not pass NULL to GetAsString(). (Closed)

Created:
7 years, 10 months ago by Jun Mukai

Modified:
7 years, 10 months ago

Reviewers:
oshima, Mr4D (OOO till 08-26), sky

CC:
chromium-reviews, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Do not pass NULL to GetAsString(). base::StringValue is safe but JSONValueString is unsafe to do so. BUG=174678 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181127

Patch Set 2 : #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_app.cc	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
	M	chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_browser.cc	View	1	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

oshima

lgtm https://codereview.chromium.org/12212038/diff/1/chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_app.cc File chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_app.cc (right): https://codereview.chromium.org/12212038/diff/1/chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_app.cc#newcode141 chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_app.cc:141: std::string unused_value; nit: move it to outside of ...

7 years, 10 months ago (2013-02-06 19:11:38 UTC) #2

Jun Mukai

https://codereview.chromium.org/12212038/diff/1/chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_app.cc File chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_app.cc (right): https://codereview.chromium.org/12212038/diff/1/chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_app.cc#newcode141 chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_app.cc:141: std::string unused_value; On 2013/02/06 19:11:38, oshima wrote: > nit: ...

7 years, 10 months ago (2013-02-06 19:44:32 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/12212038/4001

7 years, 10 months ago (2013-02-06 22:12:31 UTC) #7

Message was sent while issue was closed.

Change committed as 181127

Expand Messages | Collapse Messages