Fix international-backslash key in Canadian French keyboard.

Fix international-backslash key in Canadian French keyboard.

Adding guillemotleft, guillemotright and degree condition into
KeyboardCodeFromXKeysym.
These KeySym is used in Canadian French keyboard.

BUG=175624
TEST=Checked with typing international-backslash key on Canadian French keyboard.


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182292

[Yusuke Sato, 2013-02-13 00:45:57]

lgtm with a nit.

https://codereview.chromium.org/12211127/diff/2001/ui/base/keycodes/keyboard_...
File ui/base/keycodes/keyboard_code_conversion_x.cc (right):

https://codereview.chromium.org/12211127/diff/2001/ui/base/keycodes/keyboard_...
ui/base/keycodes/keyboard_code_conversion_x.cc:529: int
XKeysymForWindowsKeyCode(KeyboardCode keycode, bool shift) {
please update this function too.

[Seigo Nonaka, 2013-02-13 01:01:38]

yusukes: Thank you for your review!

Adding sky@ as the owner of ui/
sky: could you take a look?

Thank you.

[Seigo Nonaka, 2013-02-13 01:02:28]

Sorry, forget replying inline comment.

https://codereview.chromium.org/12211127/diff/2001/ui/base/keycodes/keyboard_...
File ui/base/keycodes/keyboard_code_conversion_x.cc (right):

https://codereview.chromium.org/12211127/diff/2001/ui/base/keycodes/keyboard_...
ui/base/keycodes/keyboard_code_conversion_x.cc:529: int
XKeysymForWindowsKeyCode(KeyboardCode keycode, bool shift) {
On 2013/02/13 00:45:58, Yusuke Sato wrote:
> please update this function too.

Done.

[sky, 2013-02-13 14:46:03]

LGTM - but I'm adding Dan as he knows this code better than I.

[Daniel Erat, 2013-02-13 15:45:59]

lgtm

[Seigo Nonaka, 2013-02-13 16:43:05]

Thank you for your review!
submitting...

[commit-bot: I haz the power, 2013-02-13 16:43:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nona@chromium.org/12211127/4003

[commit-bot: I haz the power, 2013-02-13 19:33:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nona@chromium.org/12211127/4003

[commit-bot: I haz the power, 2013-02-13 19:55:09]

Change committed as 182292