Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 12211125: Fixed virtual driver uninstall. (Closed)

Created:
7 years, 10 months ago by Vitaly Buka (NO REVIEWS)
Modified:
7 years, 10 months ago
Reviewers:
gene
CC:
chromium-reviews
Visibility:
Public.

Description

Fixed virtual driver uninstall. Main uninstall should be done in parent process. Child process should only delete program directory. Otherwise Windows sees that uninstall reg path still exists and shows error. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182025

Patch Set 1 : #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -23 lines) Patch
M cloud_print/virtual_driver/win/install/setup.cc View 1 5 chunks +20 lines, -23 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Vitaly Buka (NO REVIEWS)
7 years, 10 months ago (2013-02-12 09:29:32 UTC) #1
gene
lgtm
7 years, 10 months ago (2013-02-12 19:23:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/12211125/7003
7 years, 10 months ago (2013-02-12 19:32:46 UTC) #3
commit-bot: I haz the power
7 years, 10 months ago (2013-02-12 21:42:13 UTC) #4
Message was sent while issue was closed.
Change committed as 182025

Powered by Google App Engine
This is Rietveld 408576698