Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12211111: Added UMA records for OOBE portal detection. (Closed)

Created:
7 years, 10 months ago by ygorshenin1
Modified:
7 years, 10 months ago
Reviewers:
Nikita (slow)
CC:
chromium-reviews, cbentzel+watch_chromium.org, nkostylev+watch_chromium.org, gspencer+watch_chromium.org, gauravsh+watch_chromium.org, darin-cc_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Added UMA records for OOBE portal detection. Added UMA records for: * portal detection result * portal detection duration * discrepancy with shill's result BUG=174047 TEST=Manual tests on Lumpy Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181999

Patch Set 1 #

Patch Set 2 : Most of UMA records are performed in the UI context. #

Total comments: 2

Patch Set 3 : Sync, fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -1 line) Patch
M chrome/browser/chromeos/net/network_portal_detector.h View 2 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/chromeos/net/network_portal_detector.cc View 1 2 4 chunks +10 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc View 1 2 3 chunks +69 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
ygorshenin1
7 years, 10 months ago (2013-02-11 08:03:16 UTC) #1
ygorshenin1
PTAL
7 years, 10 months ago (2013-02-11 11:32:41 UTC) #2
Nikita (slow)
lgtm Don't forget to update histograms description. https://codereview.chromium.org/12211111/diff/3007/chrome/browser/chromeos/net/network_portal_detector.cc File chrome/browser/chromeos/net/network_portal_detector.cc (right): https://codereview.chromium.org/12211111/diff/3007/chrome/browser/chromeos/net/network_portal_detector.cc#newcode375 chrome/browser/chromeos/net/network_portal_detector.cc:375: UMA_HISTOGRAM_LONG_TIMES("CaptivePortal.OOBE.DetectionDuration", Comment ...
7 years, 10 months ago (2013-02-11 16:26:35 UTC) #3
ygorshenin1
Thanks! https://codereview.chromium.org/12211111/diff/3007/chrome/browser/chromeos/net/network_portal_detector.cc File chrome/browser/chromeos/net/network_portal_detector.cc (right): https://codereview.chromium.org/12211111/diff/3007/chrome/browser/chromeos/net/network_portal_detector.cc#newcode375 chrome/browser/chromeos/net/network_portal_detector.cc:375: UMA_HISTOGRAM_LONG_TIMES("CaptivePortal.OOBE.DetectionDuration", On 2013/02/11 16:26:41, Nikita Kostylev wrote: > ...
7 years, 10 months ago (2013-02-12 14:20:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ygorshenin@chromium.org/12211111/9001
7 years, 10 months ago (2013-02-12 14:21:53 UTC) #5
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=98747
7 years, 10 months ago (2013-02-12 15:11:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ygorshenin@chromium.org/12211111/9001
7 years, 10 months ago (2013-02-12 15:35:03 UTC) #7
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=98788
7 years, 10 months ago (2013-02-12 16:28:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ygorshenin@chromium.org/12211111/9001
7 years, 10 months ago (2013-02-12 16:29:05 UTC) #9
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=98832
7 years, 10 months ago (2013-02-12 17:34:20 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ygorshenin@chromium.org/12211111/9001
7 years, 10 months ago (2013-02-12 19:05:04 UTC) #11
commit-bot: I haz the power
7 years, 10 months ago (2013-02-12 20:42:17 UTC) #12
Message was sent while issue was closed. 
Change committed as 181999

Powered by Google App Engine
This is Rietveld 408576698