Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 12211101: Assert both display and system keep-alive on each capture. (Closed)

Created:
7 years, 10 months ago by Wez
Modified:
7 years, 10 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Assert both display and system keep-alive on each capture. This ensures that while the screen is actively being captured, the host system will not suspend, e.g. due to inactivity. BUG=129912 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181864

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -3 lines) Patch
M media/video/capture/screen/screen_capturer_win.cc View 1 3 chunks +13 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Wez
PTAL
7 years, 10 months ago (2013-02-09 02:17:16 UTC) #1
alexeypa (please no reviews)
lgtm https://codereview.chromium.org/12211101/diff/1/media/video/capture/screen/screen_capturer_win.cc File media/video/capture/screen/screen_capturer_win.cc (right): https://codereview.chromium.org/12211101/diff/1/media/video/capture/screen/screen_capturer_win.cc#newcode221 media/video/capture/screen/screen_capturer_win.cc:221: LOG(WARNING) << "Failed to make system & display ...
7 years, 10 months ago (2013-02-11 17:02:28 UTC) #2
Wez
https://codereview.chromium.org/12211101/diff/1/media/video/capture/screen/screen_capturer_win.cc File media/video/capture/screen/screen_capturer_win.cc (right): https://codereview.chromium.org/12211101/diff/1/media/video/capture/screen/screen_capturer_win.cc#newcode221 media/video/capture/screen/screen_capturer_win.cc:221: LOG(WARNING) << "Failed to make system & display power ...
7 years, 10 months ago (2013-02-12 01:52:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wez@chromium.org/12211101/2002
7 years, 10 months ago (2013-02-12 01:55:35 UTC) #4
commit-bot: I haz the power
7 years, 10 months ago (2013-02-12 05:08:49 UTC) #5
Message was sent while issue was closed.
Change committed as 181864

Powered by Google App Engine
This is Rietveld 408576698