Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 12211070: Run locally-built Android utils under ASan (if built with ASan). (Closed)

Created:
7 years, 10 months ago by eugenis
Modified:
7 years, 10 months ago
CC:
chromium-reviews, bulach+watch_chromium.org, yfriedman+watch_chromium.org, timurrrr+watch_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org, glider+watch_chromium.org, ilevy+watch_chromium.org, bruening+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Run locally-built Android utils under ASan (if built with ASan). In ASan build, device_forwarder and md5sum_bin are built with ASan instrumentation. Due to specifics of ASan on Android, such binaries must be prefixed with a script to run. This change also adds more app names to the wrap property list, to cover content_tests and test_shell. BUG=160952 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181309

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M build/android/pylib/valgrind_tools.py View 1 2 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Evgeniy Stepanov
7 years, 10 months ago (2013-02-07 10:44:47 UTC) #1
bulach
+frankf, craigdh as they now own build/android lgtm, thanks!
7 years, 10 months ago (2013-02-07 10:52:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eugenis@chromium.org/12211070/1005
7 years, 10 months ago (2013-02-07 12:18:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eugenis@chromium.org/12211070/1005
7 years, 10 months ago (2013-02-07 13:44:48 UTC) #4
commit-bot: I haz the power
7 years, 10 months ago (2013-02-07 15:35:01 UTC) #5
Message was sent while issue was closed.
Change committed as 181309

Powered by Google App Engine
This is Rietveld 408576698