Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4472)

Unified Diff: chrome/browser/icon_manager_linux.cc

Issue 12211049: Removing base::ThreadRestrictions::ScopedAllowIO from icon_manager_linux.cc (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review changes. Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/icon_manager_linux.cc
diff --git a/chrome/browser/icon_manager_linux.cc b/chrome/browser/icon_manager_linux.cc
index 5dfa1554fb5bb21b1e56f5dbd61c98374372c151..8ee22fab9674625eec7bd15cdd811822e0fe2385 100644
--- a/chrome/browser/icon_manager_linux.cc
+++ b/chrome/browser/icon_manager_linux.cc
@@ -7,14 +7,7 @@
#include "base/nix/mime_util_xdg.h"
#include "base/threading/thread_restrictions.h"
-IconGroupID IconManager::GetGroupIDFromFilepath(
+IconGroupID IconManager::ReadGroupIDFromFilepath(
const base::FilePath& filepath) {
- // It turns out the call to base::nix::GetFileMimeType below does IO, but
- // callers of GetGroupIDFromFilepath assume it does not do IO (the Windows
- // and Mac implementations do not). We should fix this by either not doing IO
- // in this method, or reworking callers to avoid calling it on the UI thread.
- // See crbug.com/72740.
- base::ThreadRestrictions::ScopedAllowIO allow_io;
-
return base::nix::GetFileMimeType(filepath);
}

Powered by Google App Engine
This is Rietveld 408576698