Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6381)

Unified Diff: chrome/browser/extensions/extension_service.h

Issue 12211029: Sanity tweaks to the extension blacklist: check all extensions at once on (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: more test fixes Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_service.h
diff --git a/chrome/browser/extensions/extension_service.h b/chrome/browser/extensions/extension_service.h
index 9ba30f650b26f12f79a94e8d906544ba4f8eec56..2f71d568b7bf1db72a2a785c148642f11860c3ea 100644
--- a/chrome/browser/extensions/extension_service.h
+++ b/chrome/browser/extensions/extension_service.h
@@ -61,7 +61,6 @@ class BrowserEventRouter;
class ComponentLoader;
class ContentSettingsStore;
class CrxInstaller;
-class Extension;
class ExtensionActionStorageManager;
class ExtensionSyncData;
class ExtensionSystem;
@@ -428,9 +427,8 @@ class ExtensionService
// Called when the initial extensions load has completed.
virtual void OnLoadedInstalledExtensions();
- // Adds |extension| to this ExtensionService and notifies observers than an
- // extension has been loaded. Called by the backend after an extension has
- // been loaded from a file and installed.
+ // Adds |extension| to this ExtensionService and notifies observers that the
+ // extensions have been loaded.
virtual void AddExtension(const extensions::Extension* extension) OVERRIDE;
// Check if we have preferences for the component extension and, if not or if
@@ -439,7 +437,10 @@ class ExtensionService
virtual void AddComponentExtension(const extensions::Extension* extension)
OVERRIDE;
- // Called by the backend when an extension has been installed.
+ // Informs the service that an extension's files are in place for loading.
+ //
+ // Please make sure the Blacklist is checked some time before calling this
+ // method.
void OnExtensionInstalled(
const extensions::Extension* extension,
const syncer::StringOrdinal& page_ordinal,
« no previous file with comments | « chrome/browser/extensions/extension_install_ui_default.cc ('k') | chrome/browser/extensions/extension_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698