Issue 12210144: Properly clear the controlled-by attribute if signout is allowed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12210144: Properly clear the controlled-by attribute if signout is allowed. (Closed)

Created:
7 years, 10 months ago by Andrew T Wilson (Slow)

Modified:
7 years, 10 months ago

Reviewers:
Dan Beam

CC:
chromium-reviews, dbeam+watch-options_chromium.org, arv+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Properly clear the controlled-by attribute if signout is allowed. Update JS code in settings page to clear the |controlled-by| attribute on the "Disconnect your Chromium Account" button if signout is allowed. Otherwise, this attribute could get set, but then never cleared if signout was later allowed. BUG=175709 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182245

Patch Set 1 #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	chrome/browser/resources/options/browser_options.js	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/atwilson@chromium.org/12210144/1

7 years, 10 months ago (2013-02-13 06:42:30 UTC) #3

Message was sent while issue was closed.

Change committed as 182245

Expand Messages | Collapse Messages