Issue 12210143: Refactor RegExpStub to check lazily.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12210143: Refactor RegExpStub to check lazily. (Closed)

Created:
7 years, 10 months ago by Yang

Modified:
7 years, 10 months ago

Reviewers:
ulan

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Total comments: 5

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+380 lines, -344 lines)			Patch
M	src/arm/code-stubs-arm.cc	View	1	9 chunks	+107 lines, -108 lines	0 comments	Download
M	src/ia32/code-stubs-ia32.cc	View	1	8 chunks	+141 lines, -120 lines	0 comments	Download
M	src/objects.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/x64/code-stubs-x64.cc	View	1	7 chunks	+129 lines, -116 lines	0 comments	Download

Total messages: 3 (0 generated)

ulan

LGTM if the comments are addresses. I commented on ia32 but the comments hold for ...

7 years, 10 months ago (2013-02-13 14:35:44 UTC) #2

Yang

7 years, 10 months ago (2013-02-26 09:53:14 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r13727 (presubmit successful).